You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2016/04/13 21:26:25 UTC
[jira] [Commented] (ZOOKEEPER-2413) ContainerManager doesn't close
the Timer it creates when stop() is called
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239898#comment-15239898 ]
Hadoop QA commented on ZOOKEEPER-2413:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12798547/ZOOKEEPER-2413.patch
against trunk revision 1738012.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3138//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3138//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3138//console
This message is automatically generated.
> ContainerManager doesn't close the Timer it creates when stop() is called
> -------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2413
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2413
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.1
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Attachments: ZOOKEEPER-2413.patch
>
>
> ContainerManager creates a Timer object. It's stop() method cancel's the running task but doesn't close the Timer itself. This ends up leaking a Thread (internal to the Timer).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)