[jira] [Commented] (WICKET-5028) Update Spring dependency because of classpath conflicts with cglib

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572481#comment-13572481 ] 

Martin Grigorov commented on WICKET-5028:
-----------------------------------------

You patch is not correct.
wicket-ioc should not depend on Spring. This will bring Spring for wicket-guice users too.

We should upgrade wicket-ioc to CGLib 3 and wicket-spring to Spring 3.2.1.
I'm not sure that this change can be done in Wicket 6.x series though.
                
> Update Spring dependency because of classpath conflicts with cglib
> ------------------------------------------------------------------
>
>                 Key: WICKET-5028
>                 URL: https://issues.apache.org/jira/browse/WICKET-5028
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-spring
>    Affects Versions: 6.5.0
>         Environment: wicket-ioc
>            Reporter: Thomas Götz
>         Attachments: update_spring_dependency.patch
>
>
> Scenario:
> I'm using Groovy (2.1.0) in my Wicket application which has a dependeny to asm 4.0. Wicket itself depends on cglib 2.2.2 which brings asm 3.3.1.
> -> multiple versions of asm on the classpath -> not amused ;-)
> So, I learned that Spring inlines cglib (3.0) and asm (4.0) since Spring 3.2. Would it be possible that Wicket - i.e. wicket-spring and/or wicket-ioc - depends on Spring 3.2.x, so that the dependeny to cglib can be dropped?
> I'm attaching a patch to demonstrate what this could mean. Only drawback I discovered so far: wicket-ioc whould then depend on spring-core, currently there's no dependeny on Spring in wicket-ioc.
> As an alternative we could also inline the required cglib/asm libs - as Spring also does - to avoid classpath conflicts with different version.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira