You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:41:01 UTC

[GitHub] [systemds] AlexanderErtl opened a new pull request #1146: CorrectTypos Builtin Script

AlexanderErtl opened a new pull request #1146:
URL: https://github.com/apache/systemds/pull/1146


   CorrectTypos builtin script for ExecType.CP 
   (ExecType.SPARK not currently functional)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Shafaq-Siddiqi closed pull request #1146: CorrectTypos Builtin Script

Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi closed pull request #1146:
URL: https://github.com/apache/systemds/pull/1146


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1146: CorrectTypos Builtin Script

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1146:
URL: https://github.com/apache/systemds/pull/1146#issuecomment-757271140


   LGTM,
   
   But i can see that it is a struggle to implement some of the things needed for string processing in DML.
   Especially the "generate ascii matrix" part looks painfully inefficient.
   Note that this is not a problem from your side, but a limitation in the system currently, and you have appropriately added a TODO.
   
   In the future we need to add internal functions for the system maybe Set or Map data structures in DML to enable better processing for these kinds of problems.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1146: CorrectTypos Builtin Script

Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on pull request #1146:
URL: https://github.com/apache/systemds/pull/1146#issuecomment-786601836


   Hi @AlexanderErtl  and @tim-sagaster,
   Thank you for your contribution. During the merge, I just did some minor formatting and added a TODO for the Spark test. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1146: CorrectTypos Builtin Script

Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on pull request #1146:
URL: https://github.com/apache/systemds/pull/1146#issuecomment-758283020


   Hello @AlexanderErtl,
   Thank you for your contribution. If you are still working on the Spark functionality then could you please mark your PR as "WIP" to save it from merging-in. Whenever you are ready then just remove the "WIP" and we will merge it into the master.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] Baunsgaard commented on pull request #1146: CorrectTypos Builtin Script

Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1146:
URL: https://github.com/apache/systemds/pull/1146#issuecomment-757271140


   LGTM,
   
   But i can see that it is a struggle to implement some of the things needed for string processing in DML.
   Especially the "generate ascii matrix" part looks painfully inefficient.
   Note that this is not a problem from your side, but a limitation in the system currently, and you have appropriately added a TODO.
   
   In the future we need to add internal functions for the system maybe Set or Map data structures in DML to enable better processing for these kinds of problems.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org