You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "dang-stripe (via GitHub)" <gi...@apache.org> on 2024/05/28 21:19:09 UTC
[I] Table list under tenant and instance details UI page may not show correct tables [pinot]
dang-stripe opened a new issue, #13251:
URL: https://github.com/apache/pinot/issues/13251
On the tenant details page, the table list may not show the correct tables if the table configs `instanceConfigAssignmentMap` tag does not match the server tag. The code only checks the server tenant tag currently.
The table list on the instance details page has similar behavior. Ideally both reflect the tables that are actually hosted by the servers on the tenant or tables on that specific server.
https://github.com/apache/pinot/blob/106f0c580d06661b715068617cebc35378bbc926/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTenantRestletResource.java#L291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13251:
URL: https://github.com/apache/pinot/issues/13251#issuecomment-4828066938
This issue has been automatically marked as stale because it has not had any activity in the last 150 days. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please leave a comment to keep it open. Thank you for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #13251:
URL: https://github.com/apache/pinot/issues/13251#issuecomment-5228938292
This issue has been closed because it has been inactive for 180 days. If you believe this issue is still relevant, please feel free to reopen it or create a new issue. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #13251:
URL: https://github.com/apache/pinot/issues/13251#issuecomment-2136208081
I wouldn't suggest querying server for this API for cost concern.
Tenant is kind of stale config, and I'd suggest adding an API to query all tables served by a given tag. This way we can also cover tier storage tags, and can read tags from both tenant config and `instanceConfigAssignmentMap`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "dang-stripe (via GitHub)" <gi...@apache.org>.
dang-stripe commented on issue #13251:
URL: https://github.com/apache/pinot/issues/13251#issuecomment-2138032241
That makes sense. Would this be best as a query parameter on the existing GET /tables API? Or a separate one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "dang-stripe (via GitHub)" <gi...@apache.org>.
dang-stripe commented on issue #13251:
URL: https://github.com/apache/pinot/issues/13251#issuecomment-2148016162
@Jackie-Jiang Should we be using the instance partition map instead? This came up for one of our users again where they thought the table was on their tenant but it had not been rebalanced yet. It doesn't seem like checking the table config would catch that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #13251:
URL: https://github.com/apache/pinot/issues/13251#issuecomment-2148161200
There are 3 things user might be interested in:
- The tenant that is supposed to be used to serve a table (similar to IS concept)
- The tenant that is actually used to serve a table (similar to EV concept)
- Whether the table is properly rebalanced (similar to whether IS matches EV)
IMO we can provide different APIs as following:
- Return the tables that are supposed to be served by the given tenant
- Return the tables that are actually served by the given tenant (this API can potentially be expensive because we need to compare IS for all tables with servers of the given tenant. Using `InstancePartitions` might not be good enough because not all tables have it, and it might not be in-sync with the IS)
- Return the tables that are not rebalanced (this API can be expensive, so should be called less frequently, or on a per table basis)
One more thing we didn't discuss above is how to handle `instancePartitionsMap` (reference the instance partitions of a different table) within the table config. When it is configured, we should use the `instanceAssignmentConfigMap` of the reference table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "dang-stripe (via GitHub)" <gi...@apache.org>.
dang-stripe commented on issue #13251:
URL: https://github.com/apache/pinot/issues/13251#issuecomment-2136134053
The servers have their own API for tables here: https://github.com/apache/pinot/blob/106f0c580d06661b715068617cebc35378bbc926/pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java#L147
So it's possible to have a controller API that queries all servers to see what tables are hosted by them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on issue #13251:
URL: https://github.com/apache/pinot/issues/13251#issuecomment-2138190985
Good suggestion. I think it would be great to integrate it into the list tables API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Table list under tenant and instance details UI page may not show correct tables [pinot]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #13251: Table list under tenant and instance details UI page may not show correct tables
URL: https://github.com/apache/pinot/issues/13251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org