[GitHub] [bookkeeper] zymap commented on a change in pull request #2870: Add skip unrecoverable ledger option for bookkeeper shell recover command

[GitBox <gi...@apache.org>]

zymap commented on a change in pull request #2870:
URL: https://github.com/apache/bookkeeper/pull/2870#discussion_r739925630



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java
##########
@@ -798,7 +835,7 @@ public void openComplete(int rc, final LedgerHandle lh, Object ctx) {
                         @Override
                         public void openComplete(int newrc, final LedgerHandle newlh, Object newctx) {
                             if (newrc != BKException.Code.OK) {
-                                LOG.error("BK error close ledger: " + lId, BKException.create(newrc));
+                                LOG.error("BK error close ledger: {}", lId, BKException.create(newrc));
                                 finalLedgerIterCb.processResult(newrc, null, null);

Review comment:
       Do we need to complete the `finalLedgerIterCb` normally? In the recover ledger method, I saw multiple places still failed the `finalLedgerIterCb` and it will break the recover process. Should we handle them? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org