You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2023/01/07 18:48:13 UTC

[GitHub] [shiro] lprimak commented on pull request #558: [SHIRO-899] moved the HttpSessionContext Jakarta shim into Shiro pack… (1.11.x)

lprimak commented on PR #558:
URL: https://github.com/apache/shiro/pull/558#issuecomment-1374572148

   Hi, @boris-petrov
   
   > Isn't this missing the [relocation](https://github.com/apache/shiro/pull/557/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R502) part of the other PR?
   
   Yes it does! My guess is that somehow this change was 'lost' in the cherry-pick / cleanup process.
   
   2. is incorrect because `HttpSessionContext` doesn't exist in Jakarta, hence the need for a workaround.
   3. is caused by `1`
   
   Thank you for the report
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org