You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Todd Lipcon <to...@cloudera.com> on 2010/07/29 01:22:47 UTC
Review Request: Improvements to HBaseFsck tool
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/
-----------------------------------------------------------
Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppan.
Summary
-------
Bunch of changes to the HBaseFsck tool to detect a wider variety of issues and to make it easier to add "fix" support for these problems in the future.
This addresses bug HBASE-2887.
http://issues.apache.org/jira/browse/HBASE-2887
Diffs
-----
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1
src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909
src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREATION
Diff: http://review.cloudera.org/r/418/diff
Testing
-------
Tested an earlier variation of this patch against my cluster in various screwed up states. This patch adds a basic unit test but it could be improved to use a mock cluster and test more variations.
Thanks,
Todd
Re: Review Request: Improvements to HBaseFsck tool
Posted by Alexander Georgiev <es...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review955
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment3116>
Shouldn't this be "greater than" instead of "less than"? Otherwise we are looking for errors only in elements changed in the last timelag milliseconds, which is exactly the opposite of what we want.
- Alexander
On 2010-07-28 16:22:47, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/418/
> -----------------------------------------------------------
>
> (Updated 2010-07-28 16:22:47)
>
>
> Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppan.
>
>
> Summary
> -------
>
> Bunch of changes to the HBaseFsck tool to detect a wider variety of issues and to make it easier to add "fix" support for these problems in the future.
>
>
> This addresses bug HBASE-2887.
> http://issues.apache.org/jira/browse/HBASE-2887
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1
> src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909
> src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREATION
>
> Diff: http://review.cloudera.org/r/418/diff
>
>
> Testing
> -------
>
> Tested an earlier variation of this patch against my cluster in various screwed up states. This patch adds a basic unit test but it could be improved to use a mock cluster and test more variations.
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: Improvements to HBaseFsck tool
Posted by dhruba borthakur <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review993
-----------------------------------------------------------
looks good to me.
- dhruba
On 2010-07-28 16:22:47, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/418/
> -----------------------------------------------------------
>
> (Updated 2010-07-28 16:22:47)
>
>
> Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppan.
>
>
> Summary
> -------
>
> Bunch of changes to the HBaseFsck tool to detect a wider variety of issues and to make it easier to add "fix" support for these problems in the future.
>
>
> This addresses bug HBASE-2887.
> http://issues.apache.org/jira/browse/HBASE-2887
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1
> src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909
> src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREATION
>
> Diff: http://review.cloudera.org/r/418/diff
>
>
> Testing
> -------
>
> Tested an earlier variation of this patch against my cluster in various screwed up states. This patch adds a basic unit test but it could be improved to use a mock cluster and test more variations.
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: Improvements to HBaseFsck tool
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review533
-----------------------------------------------------------
Ship it!
Looks great to me. Few comments below.
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment2127>
How do I supply different implementation of ErrorReporter?
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment2128>
What about logs dir and old logs dir -- we skipping them here?
src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java
<http://review.cloudera.org/r/418/#comment2130>
White space. Better remove it if you'd avoid wrath of BenĂ´it.
- stack
On 2010-07-28 16:22:47, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/418/
> -----------------------------------------------------------
>
> (Updated 2010-07-28 16:22:47)
>
>
> Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppan.
>
>
> Summary
> -------
>
> Bunch of changes to the HBaseFsck tool to detect a wider variety of issues and to make it easier to add "fix" support for these problems in the future.
>
>
> This addresses bug HBASE-2887.
> http://issues.apache.org/jira/browse/HBASE-2887
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1
> src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909
> src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREATION
>
> Diff: http://review.cloudera.org/r/418/diff
>
>
> Testing
> -------
>
> Tested an earlier variation of this patch against my cluster in various screwed up states. This patch adds a basic unit test but it could be improved to use a mock cluster and test more variations.
>
>
> Thanks,
>
> Todd
>
>
Re: Review Request: Improvements to HBaseFsck tool
Posted by Todd Lipcon <to...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review956
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment3119>
good catch! Yep, I think so.
- Todd
On 2010-07-28 16:22:47, Todd Lipcon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/418/
> -----------------------------------------------------------
>
> (Updated 2010-07-28 16:22:47)
>
>
> Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppan.
>
>
> Summary
> -------
>
> Bunch of changes to the HBaseFsck tool to detect a wider variety of issues and to make it easier to add "fix" support for these problems in the future.
>
>
> This addresses bug HBASE-2887.
> http://issues.apache.org/jira/browse/HBASE-2887
>
>
> Diffs
> -----
>
> src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1
> src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909
> src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREATION
>
> Diff: http://review.cloudera.org/r/418/diff
>
>
> Testing
> -------
>
> Tested an earlier variation of this patch against my cluster in various screwed up states. This patch adds a basic unit test but it could be improved to use a mock cluster and test more variations.
>
>
> Thanks,
>
> Todd
>
>