You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2026/01/12 16:42:10 UTC
[PR] Edge3 inherit core UI Theme [airflow]
pierrejeambrun opened a new pull request, #60417:
URL: https://github.com/apache/airflow/pull/60417
Getting rid of the hard copied theme.
<img width="1919" height="957" alt="Screenshot 2026-01-12 at 17 41 41" src="https://github.com/user-attachments/assets/a9f1d933-9246-4f77-827c-8951f52f31c9" />
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Edge3 inherit core UI Theme [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #60417:
URL: https://github.com/apache/airflow/pull/60417#issuecomment-3743442962
I can keep the hardcoded "theme" around as a fallback if preferable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Edge3 inherit core UI Theme [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #60417:
URL: https://github.com/apache/airflow/pull/60417#issuecomment-3740756533
Same on main:
<img width="1476" height="654" alt="image" src="https://github.com/user-attachments/assets/b93c7f05-90a2-49c4-a32c-c6bdaa341214" />
<img width="1579" height="647" alt="image" src="https://github.com/user-attachments/assets/88ccb405-6e9e-4594-8691-07ce9b15cf1e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Edge3 inherit core UI Theme [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #60417:
URL: https://github.com/apache/airflow/pull/60417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Edge3 inherit core UI Theme [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #60417:
URL: https://github.com/apache/airflow/pull/60417#issuecomment-3740581120
Mhm, okay tested with Airflow 2.1.5 and with this applied all colors are "gone" :-( All table content is just B/W.
Is there a way of fallback until we drop "old" Airflow releases 3.1.1 - 3.1.6?
<img width="1502" height="869" alt="image" src="https://github.com/user-attachments/assets/ec31ec3c-2952-480b-a8a4-deeb06c47ea2" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Edge3 inherit core UI Theme [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #60417:
URL: https://github.com/apache/airflow/pull/60417#issuecomment-3772311629
Updated. As discussed, keeping the vendored in core theme as fallback for now. I'll prepare the follow up PR for deletion that we can merge once 3.2 is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Edge3 inherit core UI Theme [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #60417:
URL: https://github.com/apache/airflow/pull/60417#issuecomment-3740523396
Ah, did not see this PR before asking the question in the other PR... is this backwards-compatible to all Airflow 3.x versions or only 3.1.7++?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Edge3 inherit core UI Theme [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #60417:
URL: https://github.com/apache/airflow/pull/60417#issuecomment-3770079647
Sorry for getting back to you late. Was distracted in a couple of other things... still on my response list :-D
I think the most-ugly thing is the coloring of status badges - would it be possible just to make these colored as a fallback and keep the private theme with this? I think it is beneficial if we do not have theming in the providers redundantly.
As I see you had a fallback implemented in https://github.com/apache/airflow/pull/60417/changes#diff-0911b95b0582829832b6bfba602604d167d26d7b7cec6d91d7ebc30b49635cb5R43 - can we just keep a minimal theme.js with just the colored buttons as fallback? Then I'd be OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Edge3 inherit core UI Theme [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #60417:
URL: https://github.com/apache/airflow/pull/60417#issuecomment-3770081958
And I'd be OK to drop the fallback in a few months but if we release a new edge version in ~2 weeks and need to pin it >3.1.7 then it will be un-usable until we also released 3.1.7...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org