[GitHub] spark pull request: [SPARK-12330] [MESOS] Fix mesos coarse mode cl...

[drcrallen <gi...@git.apache.org>]

Github user drcrallen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10319#discussion_r54676391
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala ---
    @@ -364,7 +379,29 @@ private[spark] class CoarseMesosSchedulerBackend(
       }
     
       override def stop() {
    -    super.stop()
    +    // Make sure we're not launching tasks during shutdown
    +    stateLock.synchronized {
    +      if (stopCalled) {
    +        logWarning("Stop called multiple times, ignoring")
    +        return
    +      }
    +      stopCalled = true
    +      super.stop()
    +    }
    +    // Wait for executors to report done, or else mesosDriver.stop() will forcefully kill them.
    +    // See SPARK-12330
    +    val stopwatch = new Stopwatch()
    --- End diff --
    
    Sounds good. Sorry, didn't see this note until now, and it looks like this was already fixed in master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org