You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by yu...@apache.org on 2013/09/03 10:13:40 UTC

git commit: TS-2173: RECD_COUNTER type is missing in setTokenValue()

Updated Branches:
  refs/heads/master 3fed45cdc -> 8d95ab2f0


TS-2173: RECD_COUNTER type is missing in setTokenValue()

After applied "TS-1740: Improve precision of stats values" patch,
each token will keep its original type instead of forcing to RecFloat.

So we should update setTokenValue() to deal with RECD_COUNTER case.

Signed-off-by: Yunkai Zhang <qi...@taobao.com>


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/8d95ab2f
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/8d95ab2f
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/8d95ab2f

Branch: refs/heads/master
Commit: 8d95ab2f08842e6447b9617f0ad73a8d64ab3d7b
Parents: 3fed45c
Author: Yunkai Zhang <qi...@taobao.com>
Authored: Tue Sep 3 15:29:51 2013 +0800
Committer: Yunkai Zhang <qi...@taobao.com>
Committed: Tue Sep 3 16:12:55 2013 +0800

----------------------------------------------------------------------
 CHANGES                | 2 ++
 mgmt/stats/StatType.cc | 1 +
 2 files changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/8d95ab2f/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 5a80c2f..455bdcf 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,8 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache Traffic Server 4.1.0
 
+  *) [TS-2173] RECD_COUNTER type is missing in setTokenValue()
+
   *) [TS-2165] Introduce cluster-wide logging stats
 
   *) [TS-2167] Update apichecker.pl to give suggestions on additional

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/8d95ab2f/mgmt/stats/StatType.cc
----------------------------------------------------------------------
diff --git a/mgmt/stats/StatType.cc b/mgmt/stats/StatType.cc
index 822d9f6..0017e5d 100644
--- a/mgmt/stats/StatType.cc
+++ b/mgmt/stats/StatType.cc
@@ -811,6 +811,7 @@ StatObject::setTokenValue(StatExprToken * token, bool cluster)
       break;
 
     case RECD_INT:             // fallthought
+    case RECD_COUNTER:
     case RECD_FLOAT:
       if (cluster) {
         if (!overviewGenerator->varClusterDataFromName(token->m_token_type,