[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26752: [SPARK-30112][SQL] Allow insert overwrite same table if using dynamic partition overwrite

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #26752: [SPARK-30112][SQL] Allow insert overwrite same table if using dynamic partition overwrite
URL: https://github.com/apache/spark/pull/26752#discussion_r354621289
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala
 ##########
 @@ -270,6 +270,44 @@ class InsertSuite extends DataSourceTest with SharedSparkSession {
       "INSERT OVERWRITE to a table while querying it should not be allowed.")
   }
 
+  test("it is allowed to write to a table while querying it for dynamic partition overwrite.") {
+    Seq(PartitionOverwriteMode.DYNAMIC.toString,
+        PartitionOverwriteMode.STATIC.toString).foreach { usedMode =>
 
 Review comment:
   `usedMode` -> `mode`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org