[GitHub] [superset] betodealmeida commented on issue #14061: [Table][feedback needed] 'SHOW TOTALS' in Table chart

[GitBox <gi...@apache.org>]

betodealmeida commented on issue #14061:
URL: https://github.com/apache/superset/issues/14061#issuecomment-825121413


   @junlincc we could always ask the user if the metric is additive:
   
   1. If the user adds a metric explicitly to the dataset we can have a checkbox asking if the metric is additive.
   2. For metrics defined on-the-fly with the "SIMPLE" tab we know if they're additive (`COUNT`, `SUM`) or not (`COUNT DISTINCT`, `AVG`, `MIN`, `MAX`).
   3. For metrics defined on-the-fly under "CUSTOM SQL" we can have a checkbox asking the user.
   
   
    we can also have a checkbox in the metric configuration dialog asking if the metric is additive, and have it disabled for aggregation functions that we know are not additive, like `AVG` and enabled for those we know are additive. This would work for the 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org