You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/10/24 23:11:36 UTC
[GitHub] incubator-beam pull request #1178: [BEAM-498] Remove some more uses of OldDo...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1178
[BEAM-498] Remove some more uses of OldDoFn
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @tgroh
In the DirectRunner tests, I ported the syntax, though not the logic since it doesn't actually run yet. I'm not totally certain these tests are needed beyond future ROS tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam ValueWithRecordId
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1178
----
commit 3a2f5d1c720590eabee7667b686533f762698297
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-10-24T22:57:18Z
Remove use of OldDoFn in ValueWithRecordId
commit 4219bb5493c3b9f70ccdf78d8820649453cf0a6d
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-10-24T23:09:13Z
Remove use of OldDoFn from some DirectRunner tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1178: [BEAM-498] Remove some more uses of OldDo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---