You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/26 14:39:08 UTC
[GitHub] [superset] nikolagigic opened a new pull request #12770: chore(explore): Reorder dataset search results based on property relevance
nikolagigic opened a new pull request #12770:
URL: https://github.com/apache/superset/pull/12770
### SUMMARY
Reorder dataset search results based on property relevance (**column_name / metric_name**, **description**, **verbose_name**, **expression**)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
1. Go to any **chart**
2. Search the **dataset** for any **term**
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (d96e42a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **increase** coverage by `4.43%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
+ Coverage 66.93% 71.36% +4.43%
==========================================
Files 1022 534 -488
Lines 50051 19942 -30109
Branches 4915 5051 +136
==========================================
- Hits 33500 14231 -19269
+ Misses 16426 5587 -10839
+ Partials 125 124 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.84% <0.00%> (-0.03%)` | :arrow_down: |
| javascript | `61.65% <9.09%> (+0.14%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `66.66% <9.09%> (-13.34%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | | |
| [superset/migrations/versions/5ccf602336a0\_.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81Y2NmNjAyMzM2YTBfLnB5) | | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | | |
| [superset/migrations/versions/4e6a06bad7a8\_init.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80ZTZhMDZiYWQ3YThfaW5pdC5weQ==) | | |
| [...6819ee0e3\_fix\_wrong\_constraint\_on\_table\_columns.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xMjI2ODE5ZWUwZTNfZml4X3dyb25nX2NvbnN0cmFpbnRfb25fdGFibGVfY29sdW1ucy5weQ==) | | |
| [...migrations/versions/836c0bf75904\_cache\_timeouts.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84MzZjMGJmNzU5MDRfY2FjaGVfdGltZW91dHMucHk=) | | |
| [superset/migrations/versions/ea033256294a\_.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lYTAzMzI1NjI5NGFfLnB5) | | |
| [superset/examples/multiformat\_time\_series.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlmb3JtYXRfdGltZV9zZXJpZXMucHk=) | | |
| [superset/css\_templates/schemas.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9zY2hlbWFzLnB5) | | |
| ... and [482 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...d96e42a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (27c5cd2) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.74% -3.20%
==========================================
Files 1022 488 -534
Lines 50051 30117 -19934
Branches 4915 0 -4915
==========================================
- Hits 33500 19197 -14303
+ Misses 16426 10920 -5506
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | | |
| [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | | |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | | |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...29aebdf](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (d96e42a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `0.12%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 66.80% -0.13%
==========================================
Files 1022 1022
Lines 50051 50059 +8
Branches 4915 5051 +136
==========================================
- Hits 33500 33443 -57
- Misses 16426 16492 +66
+ Partials 125 124 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.84% <0.00%> (-0.03%)` | :arrow_down: |
| javascript | `61.65% <9.09%> (+0.14%)` | :arrow_up: |
| python | `63.79% <ø> (-0.31%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `66.66% <9.09%> (-13.34%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.93% <0.00%> (-2.46%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...d96e42a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767726461
@junlincc @rusackas @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (d96e42a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `16.08%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
===========================================
- Coverage 66.93% 50.84% -16.09%
===========================================
Files 1022 477 -545
Lines 50051 17141 -32910
Branches 4915 4425 -490
===========================================
- Hits 33500 8716 -24784
+ Misses 16426 8425 -8001
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.84% <0.00%> (-0.03%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `61.90% <0.00%> (-18.10%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (-85.95%)` | :arrow_down: |
| ... and [878 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...d96e42a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564984260
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
<img src="https://user-images.githubusercontent.com/335541/105934799-b4d6a180-6005-11eb-93e5-997c59cc45b5.png" width="300">
Can confirm this solution works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (6ced15a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 66.79% -0.14%
==========================================
Files 1022 1022
Lines 50051 50049 -2
Branches 4915 4914 -1
==========================================
- Hits 33500 33429 -71
- Misses 16426 16496 +70
+ Partials 125 124 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `61.70% <ø> (+0.19%)` | :arrow_up: |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.00% <ø> (+5.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `46.76% <0.00%> (-0.02%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `100.00% <0.00%> (+18.18%)` | :arrow_up: |
| [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `96.15% <0.00%> (+19.23%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6ced15a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (6ced15a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `5.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 61.70% -5.23%
==========================================
Files 1022 534 -488
Lines 50051 19913 -30138
Branches 4915 4914 -1
==========================================
- Hits 33500 12288 -21212
+ Misses 16426 7425 -9001
- Partials 125 200 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.70% <ø> (+0.19%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.00% <ø> (+5.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [674 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6ced15a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (29aebdf) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.40% -3.53%
==========================================
Files 1022 488 -534
Lines 50051 30115 -19936
Branches 4915 0 -4915
==========================================
- Hits 33500 19095 -14405
+ Misses 16426 11020 -5406
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.40% <ø> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [543 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...29aebdf](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (faf32ce) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `7.85%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 59.07% -7.86%
==========================================
Files 1022 965 -57
Lines 50051 47250 -2801
Branches 4915 4423 -492
==========================================
- Hits 33500 27914 -5586
- Misses 16426 19336 +2910
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <0.00%> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.42% <0.00%> (-11.58%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (-85.95%)` | :arrow_down: |
| ... and [395 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...faf32ce](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-768324148
This commit should fix all the issues commented above:
1. Will sort only by keyword occurrence
2. Acronyms will be filtered out
3. Verbose/column name will come before description/expression
4. Descriptions with new lines will be formatted to search format
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-768555621
Test results:
1. 🟢
2. What is acronym in this case? 🟡 @nikolagigic
3. I place END and items with END in the name are first before items with END in phrase 🟢
4. works but small issue there. I guess new line should not be consumed without adding space. Can we make this better? Have a look 🟡 :
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r565092243
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
@nikolagigic to the end users, verbose names and metric/column names are almost indistinguishable in the list (except casing difference enforced only by convention), so I'm not sure ranking verbose names lower make that much of a difference.
I also noticed two other problems:
1. When using `minRanking`, items are promoted to the top as long as there is a simple match (e.g. `evt` will match `event` because letters occur in the same order), which IMO is not very useful for most cases. For example, in your screenshots, `end` probably shouldn't match `codeevnt_xxxx`. I don't consider this a high priority bug, but if we do want to fix it, the cleanest solution is probably still the multi-step search you originally did in this PR. Sorry for the back and forth.
2. Fields with new lines are not fully searchable. For example, "Highest Degree Earned" has SQL expression:
```
CASE
WHEN ....
```
but searching for "case when" will not produce a match.
We may want to do something like this:
```ts
columns: matchSorter(columns, value, {
keys: [
{
key: item =>
[item.verbose_name, item.column_name].map(
x => x?.replace(/[_\n\s]+/g, ' ') || '',
),
minRanking: rankings.EQUAL,
},
{
key: item =>
[item.description, item.expression].map(
x => x?.replace(/[_\n\s]+/g, ' ') || '',
),
threshold: rankings.CONTAINS,
},
],
keepDiacritics: true,
}),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (10d8807) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.71% -3.23%
==========================================
Files 1022 488 -534
Lines 50051 30102 -19949
Branches 4915 0 -4915
==========================================
- Hits 33500 19178 -14322
+ Misses 16426 10924 -5502
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.71% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [539 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6c6ab81](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (faf32ce) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `9.24%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 57.69% -9.25%
==========================================
Files 1022 965 -57
Lines 50051 47250 -2801
Branches 4915 4423 -492
==========================================
- Hits 33500 27259 -6241
- Misses 16426 19991 +3565
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `47.05% <0.00%> (-3.82%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.42% <0.00%> (-11.58%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `3.79% <0.00%> (-87.22%)` | :arrow_down: |
| ... and [412 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...faf32ce](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564789578
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
`verbose_name` should rank first because it is what's been displayed to the end user.
I would also suggest adding back the different rankings since as it's very unlikely people would search description or SQL expressions by acronyms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (faf32ce) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.71% -3.22%
==========================================
Files 1022 488 -534
Lines 50051 30102 -19949
Branches 4915 0 -4915
==========================================
- Hits 33500 19179 -14321
+ Misses 16426 10923 -5503
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.71% <ø> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.94% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.44% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| ... and [538 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...faf32ce](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r565040471
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
using **EQUAL** for verbose_name would still rank some of the columns with the acronym of a keyword higher.
Howver using **ACRONYM** instead would solve the issue imo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564785396
##########
File path: superset-frontend/spec/javascripts/explore/components/DatasourcePanel_spec.jsx
##########
@@ -66,4 +77,47 @@ describe('datasourcepanel', () => {
expect(screen.getByText('Columns')).toBeTruthy();
expect(screen.getByText('Metrics')).toBeTruthy();
});
+
+ it('should render search results', () => {
+ const { container } = render(
+ <ThemeProvider theme={supersetTheme}>
+ <DatasourcePanel {...props} />
+ </ThemeProvider>,
+ );
Review comment:
You can use
```ts
/**
* @jest-environment jsdom
*/
import { render } from 'spec/helpers/testing-library';
```
It adds the `ThemeProvider` for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r565092243
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
@nikolagigic to the end users, verbose names and metric/column names are almost indistinguishable in the list (except casing difference enforced only by convention), so I'm not sure ranking verbose names lower make that much of a difference.
I also noticed two other problems:
1. When using `minRanking`, items are promoted to the top as long as there is a simple match (e.g. `evt` will match `event` because letters occur in the same order), which IMO is not very useful for most cases. For example, in your screenshots, `end` probably shouldn't match `codeevnt_xxxx`. I don't consider this a high priority bug, but if we do want to fix it, the cleanest solution is probably still the multi-step search you originally did in this PR. Sorry for the back and forth.
2. Fields with new lines are not fully searchable. For example, "Highest Degree Earned" has SQL expression:
```
CASE
WHEN ....
```
but searching for "case when" will not produce a match.
A solution would be to use a functional `key`:
```ts
columns: matchSorter(columns, value, {
keys: [
{
key: item =>
[item.verbose_name, item.column_name].map(
x => x?.replace(/[_\n\s]+/g, ' ') || '',
),
minRanking: rankings.EQUAL,
},
{
key: item =>
[item.description, item.expression].map(
x => x?.replace(/[_\n\s]+/g, ' ') || '',
),
threshold: rankings.CONTAINS,
},
],
keepDiacritics: true,
}),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-768617508
@adam-stasiak
2. **calc_first_time_dev => cftd**
4. I dont understand your question here. If it's not in the original scope, make another issue for this and assign it to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564982422
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
Changing the ranking of `description` and `expression` from the default `MATCHES` to `CONTAINS` is a separate issue from the ranking across properties. It's not the reason why they were ranked higher when they shouldn't.
After reading more closely on [`match-sorter`'s doc](https://www.npmjs.com/package/match-sorter), I think you can achieve the same thing (rank `description` and `expression` lower) by utilizing the `minRanking` option.
Changes based on my original code:
```ts
setList({
columns: matchSorter(columns, value, {
keys: [
{
key: 'verbose_name',
minRanking: rankings.EQUAL,
},
{
key: 'column_name',
minRanking: rankings.EQUAL,
},
{
key: 'description',
threshold: rankings.CONTAINS,
},
{
key: 'expression',
threshold: rankings.CONTAINS,
},
],
keepDiacritics: true,
}),
metrics: matchSorter(metrics, value, {
keys: [
{
key: 'verbose_name',
minRanking: rankings.EQUAL,
},
{
key: 'metric_name',
minRanking: rankings.EQUAL,
},
{
key: 'description',
threshold: rankings.CONTAINS,
},
{
key: 'expression',
threshold: rankings.CONTAINS,
},
],
keepDiacritics: true,
baseSort: (a, b) =>
Number(b.item.is_certified) - Number(a.item.is_certified) ||
String(a.rankedValue).localeCompare(b.rankedValue),
}),
});
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r565040471
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
using **EQUAL** for verbose_name would still rank some of the columns with the acronym of a keyword higher.
Howver using **ACRONYM** instead would solve the issue imo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (10d8807) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.38% -3.55%
==========================================
Files 1022 488 -534
Lines 50051 30102 -19949
Branches 4915 0 -4915
==========================================
- Hits 33500 19081 -14419
+ Misses 16426 11021 -5405
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.55% <0.00%> (-5.47%)` | :arrow_down: |
| ... and [553 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6c6ab81](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
junlincc commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r565048663
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
@ktmud if we can resolve above ^, I agree `verbose_name` should rank higher. clearly i still have a lot to learn in Superset. thanks for clarifying
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (6c6ab81) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.80% -3.13%
==========================================
Files 1022 488 -534
Lines 50051 30117 -19934
Branches 4915 0 -4915
==========================================
- Hits 33500 19216 -14284
+ Misses 16426 10901 -5525
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.80% <ø> (-0.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.32% <0.00%> (-0.27%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | | |
| ... and [532 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...d96e42a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (d96e42a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `0.35%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 66.57% -0.36%
==========================================
Files 1022 1022
Lines 50051 50044 -7
Branches 4915 5051 +136
==========================================
- Hits 33500 33316 -184
- Misses 16426 16604 +178
+ Partials 125 124 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.84% <0.00%> (-0.03%)` | :arrow_down: |
| javascript | `61.65% <9.09%> (+0.14%)` | :arrow_up: |
| python | `63.40% <ø> (-0.70%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `66.66% <9.09%> (-13.34%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...d96e42a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564978999
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
<img width="936" alt="verbose-name" src="https://user-images.githubusercontent.com/335541/105932285-8e166c00-6001-11eb-8aae-d594f42c5672.png">
`verbose_name` is the metric/column label when specified. It take precedent of `metric_name` and `column_name` in the UI. The logic is, if `verbose_name` is set, use `verbose_name`, otherwise fallback to `metric_name` or `column_name`. Funny thing is, when `verbose_name` is set, there is actually no way in the UI to view what the underlying `metric_name` and `column_name` is. We may or may not want to do something about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
junlincc commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r565048663
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
@ktmud if we can resolve above ^, I agree `verbose_name` should rank higher. clearly i still have a lot to learn in Superset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (10d8807) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `10.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
===========================================
- Coverage 66.93% 56.45% -10.48%
===========================================
Files 1022 965 -57
Lines 50051 47257 -2794
Branches 4915 4424 -491
===========================================
- Hits 33500 26678 -6822
- Misses 16426 20579 +4153
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `43.64% <0.00%> (-7.23%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `63.41% <0.00%> (-16.59%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/dashboard/util/getDirectPathToTabIndex.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERpcmVjdFBhdGhUb1RhYkluZGV4Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...rset-frontend/src/explore/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwudHN4) | `3.79% <0.00%> (-87.22%)` | :arrow_down: |
| ... and [425 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6c6ab81](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564815370
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
the problem with this is that columns with description containing the searched keyword will go to the top, which is not what we want @junlincc could you chime in on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (6ced15a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `1.76%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 65.16% -1.77%
==========================================
Files 1022 1022
Lines 50051 50048 -3
Branches 4915 4914 -1
==========================================
- Hits 33500 32616 -884
- Misses 16426 17283 +857
- Partials 125 149 +24
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `42.52% <ø> (-8.35%)` | :arrow_down: |
| javascript | `61.70% <ø> (+0.19%)` | :arrow_up: |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.00% <ø> (+5.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/dashboardInfo.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8uanM=) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `19.23% <0.00%> (-61.54%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.34% <0.00%> (-48.83%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [...ls/DateFilterControl/frame/DateFunctionTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9EYXRlRnVuY3Rpb25Ub29sdGlwLnRzeA==) | `58.33% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [97 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6ced15a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (d96e42a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `0.36%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 66.56% -0.37%
==========================================
Files 1022 1022
Lines 50051 50059 +8
Branches 4915 5051 +136
==========================================
- Hits 33500 33323 -177
- Misses 16426 16612 +186
+ Partials 125 124 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.84% <0.00%> (-0.03%)` | :arrow_down: |
| javascript | `61.65% <9.09%> (+0.14%)` | :arrow_up: |
| python | `63.39% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `66.66% <9.09%> (-13.34%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...d96e42a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (10d8807) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `8.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 58.93% -8.01%
==========================================
Files 1022 965 -57
Lines 50051 47257 -2794
Branches 4915 4424 -491
==========================================
- Hits 33500 27849 -5651
- Misses 16426 19408 +2982
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.47% <0.00%> (-0.40%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `63.41% <0.00%> (-16.59%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (-85.95%)` | :arrow_down: |
| ... and [395 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6c6ab81](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (6ced15a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `4.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 62.91% -4.02%
==========================================
Files 1022 1022
Lines 50051 50015 -36
Branches 4915 4914 -1
==========================================
- Hits 33500 31466 -2034
- Misses 16426 18349 +1923
- Partials 125 200 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.70% <ø> (+0.19%)` | :arrow_up: |
| python | `63.71% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.00% <ø> (+5.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [202 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6ced15a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564982422
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
Changing the ranking of `description` and `expression` from the default `MATCHES` to `CONTAINS` is a separate issue from the ranking across properties.
After reading more closely on [`match-sorter`'s doc](https://www.npmjs.com/package/match-sorter), I think you can achieve the same thing (rank `description` and `expression` lower) by utilizing the `minRanking` option.
Changes based on my original code:
```ts
setList({
columns: matchSorter(columns, value, {
keys: [
{
key: 'verbose_name',
minRanking: rankings.EQUAL,
},
{
key: 'column_name',
minRanking: rankings.EQUAL,
},
{
key: 'description',
threshold: rankings.CONTAINS,
},
{
key: 'expression',
threshold: rankings.CONTAINS,
},
],
keepDiacritics: true,
}),
metrics: matchSorter(metrics, value, {
keys: [
{
key: 'verbose_name',
minRanking: rankings.EQUAL,
},
{
key: 'metric_name',
minRanking: rankings.EQUAL,
},
{
key: 'description',
threshold: rankings.CONTAINS,
},
{
key: 'expression',
threshold: rankings.CONTAINS,
},
],
keepDiacritics: true,
baseSort: (a, b) =>
Number(b.item.is_certified) - Number(a.item.is_certified) ||
String(a.rankedValue).localeCompare(b.rankedValue),
}),
});
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (faf32ce) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.38% -3.55%
==========================================
Files 1022 488 -534
Lines 50051 30102 -19949
Branches 4915 0 -4915
==========================================
- Hits 33500 19081 -14419
+ Misses 16426 11021 -5405
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.55% <0.00%> (-5.47%)` | :arrow_down: |
| ... and [553 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...faf32ce](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (6ced15a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.99%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 62.93% -4.00%
==========================================
Files 1022 1022
Lines 50051 50030 -21
Branches 4915 4914 -1
==========================================
- Hits 33500 31485 -2015
- Misses 16426 18345 +1919
- Partials 125 200 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.70% <ø> (+0.19%)` | :arrow_up: |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.00% <ø> (+5.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [191 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6ced15a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (10d8807) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `7.86%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 59.06% -7.87%
==========================================
Files 1022 965 -57
Lines 50051 47257 -2794
Branches 4915 4424 -491
==========================================
- Hits 33500 27913 -5587
- Misses 16426 19344 +2918
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.85% <0.00%> (-0.03%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `63.41% <0.00%> (-16.59%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (-85.95%)` | :arrow_down: |
| ... and [395 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6c6ab81](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
junlincc commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564943074
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
what's been displayed to the end user is` metric_name` or `column name`. `verbose_name` is auto generated and show by default when these two are missing, kinda random we believe? or can you explain how `verbose_name` is generated and how to change it in the UI. @ktmud
and yes, we don't want columns with description containing the searched keyword goes to the top. @nikolagigic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (81aa4f6) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.52%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.40% -3.53%
==========================================
Files 1022 488 -534
Lines 50051 30115 -19936
Branches 4915 0 -4915
==========================================
- Hits 33500 19095 -14405
+ Misses 16426 11020 -5406
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.40% <ø> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.59% <0.00%> (-3.27%)` | :arrow_down: |
| ... and [543 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...81aa4f6](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r565040471
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
using **EQUAL** for verbose_name would still rank some of the columns with the acronym of a keyword higher.
Howver using **ACRONYM** instead would solve the issue imo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r565092243
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
@nikolagigic to the end users, verbose names and metric/column names are almost indistinguishable in the list (except casing difference enforced only by convention), so I'm not sure ranking verbose names lower make that much of a difference.
I also noticed two other problems:
1. When using `minRanking`, items are promoted to the top as long as there is a simple match (e.g. `evt` will match `event` because letters occur in the same order), which IMO is not very useful for most cases. For example, in your screenshots, `end` probably shouldn't match `codeevnt_xxxx`. I don't consider this a high priority bug, but if we do want to fix it, the cleanest solution is probably still the multi-step search you originally did in this PR. Sorry for the back and forth.
2. Fields with new lines are not fully searchable. For example, "Highest Degree Earned" has SQL expression:
```
CASE
WHEN ....
```
but searching for "case when" will not produce a match.
The solution would be to use a functional `key`:
```ts
columns: matchSorter(columns, value, {
keys: [
{
key: item =>
[item.verbose_name, item.column_name].map(
x => x?.replace(/[_\n\s]+/g, ' ') || '',
),
minRanking: rankings.EQUAL,
},
{
key: item =>
[item.description, item.expression].map(
x => x?.replace(/[_\n\s]+/g, ' ') || '',
),
threshold: rankings.CONTAINS,
},
],
keepDiacritics: true,
}),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (6ced15a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `4.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 62.71% -4.22%
==========================================
Files 1022 1022
Lines 50051 50015 -36
Branches 4915 4914 -1
==========================================
- Hits 33500 31369 -2131
- Misses 16426 18446 +2020
- Partials 125 200 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.70% <ø> (+0.19%)` | :arrow_up: |
| python | `63.38% <ø> (-0.71%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.00% <ø> (+5.00%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [216 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6ced15a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-768663658
@adam-stasiak thanks for the extensive testing! I think case 4 is an acceptable behavior if you mean "word1 word2" is also matching "word1word2".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12770:
URL: https://github.com/apache/superset/pull/12770#discussion_r564789578
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -109,45 +111,41 @@ export default function DataSourcePanel({
metrics,
});
+ function searchByRelevance(
+ datasource: Array<ColumnMeta | Metric>,
+ value: string,
+ isMetrics = false,
+ ) {
+ const properties = [
+ isMetrics ? 'metric_name' : 'column_name',
+ 'description',
+ 'verbose_name',
Review comment:
`verbose_name` should rank first because it is what's been displayed to the end user.
I would also suggest adding back the different rankings since it's very unlikely people would search description or SQL expressions by acronyms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (faf32ce) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `7.98%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 58.94% -7.99%
==========================================
Files 1022 965 -57
Lines 50051 47250 -2801
Branches 4915 4423 -492
==========================================
- Hits 33500 27850 -5650
- Misses 16426 19400 +2974
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.50% <0.00%> (-0.37%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `68.42% <0.00%> (-11.58%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (-85.95%)` | :arrow_down: |
| ... and [395 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...faf32ce](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12770:
URL: https://github.com/apache/superset/pull/12770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (6ced15a) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `0.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 66.70% -0.23%
==========================================
Files 1022 1022
Lines 50051 50049 -2
Branches 4915 4914 -1
==========================================
- Hits 33500 33386 -114
- Misses 16426 16535 +109
- Partials 125 128 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.50% <ø> (-0.37%)` | :arrow_down: |
| javascript | `61.70% <ø> (+0.19%)` | :arrow_up: |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `85.00% <ø> (+5.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.58% <0.00%> (-5.07%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.08% <0.00%> (-3.83%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `38.42% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...6ced15a](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12770: chore(explore): Reorder dataset search results based on property relevance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12770:
URL: https://github.com/apache/superset/pull/12770#issuecomment-767598954
# [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=h1) Report
> Merging [#12770](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=desc) (27c5cd2) into [master](https://codecov.io/gh/apache/superset/commit/6bf5d2c06dcdd981b3391223526d1aa6d979edcd?el=desc) (6bf5d2c) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12770 +/- ##
==========================================
- Coverage 66.93% 63.71% -3.23%
==========================================
Files 1022 488 -534
Lines 50051 30117 -19934
Branches 4915 0 -4915
==========================================
- Hits 33500 19188 -14312
+ Misses 16426 10929 -5497
+ Partials 125 0 -125
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.71% <ø> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.45% <0.00%> (-0.52%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.32% <0.00%> (-0.27%)` | :arrow_down: |
| ... and [533 more](https://codecov.io/gh/apache/superset/pull/12770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=footer). Last update [6bf5d2c...29aebdf](https://codecov.io/gh/apache/superset/pull/12770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org