You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/22 22:39:44 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7868: [SQL Lab]
Fix TableSelector perf for large option sets
codecov-io commented on issue #7868: [SQL Lab] Fix TableSelector perf for large option sets
URL: https://github.com/apache/incubator-superset/pull/7868#issuecomment-513981653
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7868?src=pr&el=h1) Report
> Merging [#7868](https://codecov.io/gh/apache/incubator-superset/pull/7868?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee3430cce5ccfb073522a8388abbbdd68e1eed0b?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7868/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7868?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7868 +/- ##
==========================================
+ Coverage 65.8% 65.83% +0.02%
==========================================
Files 461 461
Lines 22210 22210
Branches 2425 2425
==========================================
+ Hits 14616 14621 +5
+ Misses 7473 7468 -5
Partials 121 121
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7868?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `84.16% <100%> (ø)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/7868/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.45% <0%> (+22.72%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7868?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7868?src=pr&el=footer). Last update [ee3430c...28f591a](https://codecov.io/gh/apache/incubator-superset/pull/7868?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org