You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Konstantin Boudnik (JIRA)" <ji...@apache.org> on 2009/08/04 00:04:14 UTC
[jira] Created: (HDFS-520) Create new tests for block recovery
Create new tests for block recovery
-----------------------------------
Key: HDFS-520
URL: https://issues.apache.org/jira/browse/HDFS-520
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Konstantin Boudnik
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reassigned HDFS-520:
---------------------------------------
Assignee: (was: Konstantin Boudnik)
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HDFS-520:
-------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
0.21.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Hairong Kuang
> Fix For: 0.21.0, 0.22.0
>
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, blockRecoveryPositive2_0.21.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-520:
------------------------------------
Component/s: test
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reassigned HDFS-520:
---------------------------------------
Assignee: Konstantin Boudnik
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848574#action_12848574 ]
Hudson commented on HDFS-520:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #220 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/220/])
. Create new tests for block recovery. Contributed by Hairong.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Hairong Kuang
> Fix For: 0.21.0, 0.22.0
>
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, blockRecoveryPositive2_0.21.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836881#action_12836881 ]
Konstantin Boudnik commented on HDFS-520:
-----------------------------------------
Yup, it does the trick. I've ran the tests are both seems to be running fine now.
+1 on the patch.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HDFS-520:
-------------------------------
Attachment: blockRecoveryPositive.patch
Here is a new patch that addressed all Cos's comments.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive.patch
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853957#action_12853957 ]
Hudson commented on HDFS-520:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #275 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/])
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Hairong Kuang
> Fix For: 0.21.0, 0.22.0
>
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, blockRecoveryPositive2_0.21.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HDFS-520:
-------------------------------
Attachment: blockRecoveryPositive.patch
This patch imlements the block recovery tests described in section 5.
1. TestBlockRecovery covers BlockRecovery_02.8 - 13.
2. TestLeaseRecovery2#testHardLeaseRecovery is a funcational test that covers BlockRecovery_02 (02.1-02.5,) and BlockRecovery_03, 03.1, 04.
3. I do not think BlockRecovery_02.6 is in the scope of this test.
4. BlockRecovery_01 is a negative test that will be covered in the negative test suite.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reassigned HDFS-520:
---------------------------------------
Assignee: Hairong Kuang (was: Konstantin Boudnik)
Clearly, Hairong was working on this.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Hairong Kuang
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HDFS-520:
-------------------------------
Status: Patch Available (was: Reopened)
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive.patch
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-520:
------------------------------------
Description:
According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853658#action_12853658 ]
Hudson commented on HDFS-520:
-----------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/])
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Hairong Kuang
> Fix For: 0.21.0, 0.22.0
>
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, blockRecoveryPositive2_0.21.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836524#action_12836524 ]
Hadoop QA commented on HDFS-520:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436410/TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
against trunk revision 911744.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/238/console
This message is automatically generated.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-520:
------------------------------------
Attachment: TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
Hmm, please let me know if I'm doing something wrong here, but I've tried to run
{{ant clean run-test-unit}} and all TestBlockRecovery tests have failed (see attached log)
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781495#action_12781495 ]
Allen Wittenauer commented on HDFS-520:
---------------------------------------
It seems very wrong to close this as "won't fix" just because Yahoo! doesn't want to put resources behind it at this moment. If this is still an issue, it should be left open.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik reassigned HDFS-520:
---------------------------------------
Assignee: Konstantin Boudnik
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HDFS-520:
-------------------------------
Attachment: (was: blockRecoveryPositive.patch)
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HDFS-520:
-------------------------------
Attachment: blockRecoveryPositive2.patch
This patch fixes the failed test problem.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836020#action_12836020 ]
Hadoop QA commented on HDFS-520:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436355/blockRecoveryPositive.patch
against trunk revision 911744.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/237/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/237/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/237/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/237/console
This message is automatically generated.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848564#action_12848564 ]
Hairong Kuang commented on HDFS-520:
------------------------------------
Forgot to mention that all unit tests are passed on my local machine.
I've just committed this!
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Hairong Kuang
> Fix For: 0.21.0, 0.22.0
>
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, blockRecoveryPositive2_0.21.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779804#action_12779804 ]
Konstantin Boudnik commented on HDFS-520:
-----------------------------------------
I've spent quite some time doing some refactoring of the Datanode code to make it more testable. It seems to be possible to master some tests with Mockito. However, they look more like end-to-end test eventually, because of high complexity of dependencies in the code. E.g. mocking of the datanode requires to spy on NameNode (i.e. actually initialize it) because there some calls between these two; then an actual files need to be added or proper blocks mocked and inserted to cover particular executed paths; and so on.
Which forced me to take a look at the current coverage situation of Datanode class. To my surprise I've discovered that {{recoverBlock()}} is pretty much well covered (except for some error conditions processing); {{syncBlock()}} looks even better. {{FsNameSysmtem.commitBlockSynchronization()}} seems to be Ok as well. It means that existing tests are covering this new functionality in a pretty decent fashion.
I'd suggest to drop these tests. For real.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853867#action_12853867 ]
Hudson commented on HDFS-520:
-----------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/])
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Hairong Kuang
> Fix For: 0.21.0, 0.22.0
>
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, blockRecoveryPositive2_0.21.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik resolved HDFS-520.
-------------------------------------
Resolution: Won't Fix
After discussion with HDFS dev. folks it has been decided to hold the effort of implementing this feature until more resources is available.
The risk of running into some issues is relatively low because the target code is indirectly covered by other tests (according to a Clover report)
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang reopened HDFS-520:
--------------------------------
I am reopening this. Block recovery leads to the truncation of data thus has the risk of losing data. Making sure that the tests cover all the cases is important.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835302#action_12835302 ]
Konstantin Boudnik commented on HDFS-520:
-----------------------------------------
A couple of nits:
- {{TestBlockRecovery}} has a mix of JUnit3 and JUnit4 in it. In particular
{noformat}
+import static junit.framework.Assert.assertTrue;
{noformat}
needs to be replaced with appropriate {{org.junit}} imports
- TestLeaseRecovery2#testHardLeaseRecovery uses a mix of LOG statements and invocations of {{System.out.println}}. Is it intentional?
- in general, would it make sense to add some test description in the form of JavaDoc?
Looks good otherwise!
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HDFS-520:
-------------------------------
Attachment: blockRecoveryPositive1.patch
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-520) Create new tests for block recovery
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781499#action_12781499 ]
Konstantin Boudnik commented on HDFS-520:
-----------------------------------------
'Y! doesn't want to put resources behind..." wasn't the reason to close the JIRA. It had been closed (and, btw, all the test cases in the original test plan are left intact) because it doesn't seem reasonable to develop new test cases for a code which is covered pretty well.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-520) Create new tests for block recovery
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HDFS-520:
-------------------------------
Attachment: blockRecoveryPositive2_0.21.patch
Here is a patch for 0.21.
> Create new tests for block recovery
> -----------------------------------
>
> Key: HDFS-520
> URL: https://issues.apache.org/jira/browse/HDFS-520
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Boudnik
> Assignee: Hairong Kuang
> Attachments: blockRecoveryPositive.patch, blockRecoveryPositive1.patch, blockRecoveryPositive2.patch, blockRecoveryPositive2_0.21.patch, TEST-org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.txt
>
>
> According to the test plan a number of new features are going to be implemented as a part of this umbrella (HDFS-265) JIRA.
> These new features are have to be tested properly. Block recovery is one of new functionality which require new tests to be developed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.