[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6890: Adding a new Controller API to retrieve ingestion status for realtime…

[GitBox <gi...@apache.org>]

mcvsubbu commented on pull request #6890:
URL: https://github.com/apache/incubator-pinot/pull/6890#issuecomment-843629007


   > @icefury71 @npawar
   > 
   > To avoid creating multiple debug api's on servers, I propose to consolidate the one I am creating for segments as follows:
   > 
   > 1. The api consumingSegmentsInfo will be deprecated.
   > 2. We will create a new api called segmentStatusInfo (or another name such as segmentDebugInfo) which will have:
   >    
   >    * Consumption info from 1.
   >    * Errors/exceptions related to segment
   >    * Any other info we want to add in future.
   > 3. On the controller side, these can all roll up inside the existing table debug endpoint, if we want to further consolidate.
   > 
   > We can certainly do it in steps. Please let me know your thoughts.
   
   Fine by me.
   
   Here is something that we should give a thought to. It may not look pretty in code, but will help us avoid backward incompatibility during upgrades, etc.  I suggest that we don't re-use the objects that are returned by server as controller return to the user. The advantage of using a different object to return to the user is that we can evolve the server return object (purely internal to Pinot) independent of the other one (exposed to the user). If we re-use the same one, then changing one will affect  the other, and we may be forced into some strange upgrade sequence (on a per-release basis) to keep compatibility -- if we manage to even detect the compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org