You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Peter Frank (Jira)" <ji...@apache.org> on 2019/11/07 21:42:00 UTC
[jira] [Created] (HTTPCLIENT-2028) Restore
staleConnectionCheckEnabled=true semantic behavior in
validateAfterInactivity config
Peter Frank created HTTPCLIENT-2028:
---------------------------------------
Summary: Restore staleConnectionCheckEnabled=true semantic behavior in validateAfterInactivity config
Key: HTTPCLIENT-2028
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2028
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpClient (classic)
Affects Versions: 4.5.10, 4.5.9, 4.5.8, 4.5.7, 4.5.6, 4.5.5, 4.5.4, 4.5.3, 4.5.2, 4.5.1, 4.5
Reporter: Peter Frank
Between HttpClient 4.4.x and 4.5.x setStaleConnectionCheckEnabled was deprecated in favor of setValidateAfterInactivity. That's all fine, however, the implementation of setValidateAfterInactivity has no ability to check if a connection is stale all the time. The closest one can get is 1 ms, and that's unfortunately not short enough in a test environment scenario when a test Http Server is being restarted between Tests to clear out state.
This is a common issue on the internet for people that use something like Wiremock, the irony is troubleshooting the situation makes it go away (cause logging slows the tests).
I would suggest making 0 a special value to "turn on" validation all the time.
With HttpClient 5 removing the old staleConnectionCheckEnabled completely with a piece of what that feature actually did also being removed I fear it will leave me, and perhaps others, in a bit of a lurch. Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org