[jira] [Commented] (FLINK-10794) Do not create checkpointStorage when checkpoint is disabled

["Congxian Qiu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683298#comment-16683298 ] 

Congxian Qiu commented on FLINK-10794:
--------------------------------------

hi, [~till.rohrmann], how do you think about this?

> Do not create checkpointStorage when checkpoint is disabled
> -----------------------------------------------------------
>
>                 Key: FLINK-10794
>                 URL: https://issues.apache.org/jira/browse/FLINK-10794
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Congxian Qiu
>            Assignee: Congxian Qiu
>            Priority: Major
>
> In `StreamTask#invoke` will create CheckpointStore by `stateBackend.createCheckpointStorage`, and create some directories.
> But if the checkpoint is disabled, we could skip the creation of checkpointStore.
>  
> IMO, the code could change to something like below
> {code:java}
> boolean enabledCheckpoint = configuration.getConfiguration().getBoolean("checkpointing", false);
> if (enabledCheckpoint) {
>    checkpointStorage = stateBackend.createCheckpointStorage(getEnvironment().getJobID());
> }
> {code}
>  
> or just skip the directories creation when create CheckpointStorage



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)