You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sergey Shelukhin (JIRA)" <ji...@apache.org> on 2012/10/24 02:00:11 UTC
[jira] [Created] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Sergey Shelukhin created HBASE-7038:
---------------------------------------
Summary: Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
Key: HBASE-7038
URL: https://issues.apache.org/jira/browse/HBASE-7038
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.2
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
This appears to be a major performance improvement.
I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487273#comment-13487273 ]
Hudson commented on HBASE-7038:
-------------------------------
Integrated in HBase-0.94 #560 (See [https://builds.apache.org/job/HBase-0.94/560/])
HBASE-7038 Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94 (Sergey Shelukhin) (Revision 1403787)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.94.3
>
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487032#comment-13487032 ]
Sergey Shelukhin commented on HBASE-7038:
-----------------------------------------
Thanks!
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.94.3
>
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482851#comment-13482851 ]
Hadoop QA commented on HBASE-7038:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550558/HBASE-7038.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3131//console
This message is automatically generated.
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486212#comment-13486212 ]
ramkrishna.s.vasudevan commented on HBASE-7038:
-----------------------------------------------
this should be ok... if all the tests passes +1 on this.
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490383#comment-13490383 ]
Hudson commented on HBASE-7038:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/])
HBASE-7038 Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94 (Sergey Shelukhin) (Revision 1403787)
Result = FAILURE
tedyu :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.94.3
>
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486197#comment-13486197 ]
Sergey Shelukhin commented on HBASE-7038:
-----------------------------------------
can someone please review? Thanks!
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7038:
---------------------------------
Fix Version/s: 0.94.3
+1 for 0.94.3
I looked at this patch... I mostly get it :)
Also looked through the comments on HBASE-5970.
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.94.3
>
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486269#comment-13486269 ]
Ted Yu commented on HBASE-7038:
-------------------------------
I ran the patch through test suite.
Result is green.
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7038:
------------------------------------
Issue Type: Task (was: Bug)
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-7038:
--------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Integrated to 0.94 branch.
Thanks for the patch, Sergey.
Thanks for the review, Ram and Lars.
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.94.3
>
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7038:
------------------------------------
Attachment: HBASE-7038.patch
Straightforward git apply.
The code looks safe; unloading updating timers into separate thread can hypothetically introduce a delay in this operation, but I don't think it's a problem here
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7038) Port HBASE-5970 Improve the
AssignmentManager#updateTimer and speed up handling opened event to 0.94
Posted by "Sergey Shelukhin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Shelukhin updated HBASE-7038:
------------------------------------
Status: Patch Available (was: Open)
> Port HBASE-5970 Improve the AssignmentManager#updateTimer and speed up handling opened event to 0.94
> ----------------------------------------------------------------------------------------------------
>
> Key: HBASE-7038
> URL: https://issues.apache.org/jira/browse/HBASE-7038
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.2
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HBASE-7038.patch
>
>
> This appears to be a major performance improvement.
> I will make a 0.94 port patch, please chime in on whether you think it's reasonable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira