You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/11/12 19:20:39 UTC

[GitHub] [trafficcontrol] rob05c commented on issue #4095: Remove code that is not used

rob05c commented on issue #4095: Remove code that is not used
URL: https://github.com/apache/trafficcontrol/pull/4095#issuecomment-553072785
 
 
   Copying what I put on the mailing list here:
   
   infrastructure/test/api has been superseded by the TO API Tests.
   infrastructure/test/apitest has been superseded by the TO API Tests.
   infrastructure/test/ui/traffic_ops/traffic_ops_test.go has been superseded by the Portal Tests.
   traffic_ops/client_tests has been superseded by the TO API Tests, which test the client (also, it's empty).
   traffic_ops/experimental/ats_config has been superseded by the atstccfg Config Generator.
   traffic_ops/experimental/server has been superseded by traffic_ops_golang
   
   I wrote all of the above, and I'm +1 on removing them as superseded. (Though the fact that I wrote them shouldn't prevent someone else from claiming something as useful, if anyone thinks so.)
   
   traffic_ops/experimental/goto has been superseded by traffic_ops_golang, +1 to remove.
   
   traffic_ops/experimental/auth is an experimental auth microservice for TO/TC. It hasn't been superseded by anything. We probably aren't going this direction any time soon, but I'm still hesitant to remove it as an experimental PoC.
   
   traffic_ops/experimental/postgrest hasn't been directly superseded by anything. We chose to go the traffic_ops_golang route, but PostgREST is still a valid alternative, and maybe worth keeping the PoC around.
   
   traffic_ops/experimental/traffic_ops_auth hasn't been superseded by anything in production; but it serves essentially the same purpose as traffic_ops/experimental/auth and it's much smaller. I'd be -0 on removing it.
   
   traffic_ops/experimental/url-rewriter-nginx hasn't been superseded by anything, and serves to complement traffic_ops/experimental/postgrest as a PoC for a particular way of doing TO. I'd kind of like to keep it around, for the same reason.
   traffic_ops/experimental/webfront is along the same "microservices" lines as traffic_ops_auth, url-rewriter-nginx, and postgrest. I'm +1 on keeping them around, as a PoC of a different way to do things.
   
   But, I'll defer to the list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services