[GitHub] [nifi] pvillard31 commented on a change in pull request #5451: NIFI-9231 - Add support for custom extensions in ParseCEF

[GitBox <gi...@apache.org>]

pvillard31 commented on a change in pull request #5451:
URL: https://github.com/apache/nifi/pull/5451#discussion_r726192394



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java
##########
@@ -136,6 +136,16 @@
             .defaultValue("true")
             .build();
 
+    public static final PropertyDescriptor INCLUDE_CUSTOM_EXTENSIONS = new PropertyDescriptor.Builder()
+            .name("INCLUDE_CUSTOM_EXTENSIONS")
+            .displayName("Include custom extensions")
+            .description("If set to true, custom extensions (not specified in the CEF specifications) will be "
+                    + "included in the generated data/attributes.")
+            .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
+            .required(true)

Review comment:
       Since it's a boolean property and since we provide a default value, setting it as required does not have any impact in terms of backward compatibility I believe. If someone upgrades, the property will be added with default value = false and it'll be just fine. I set the default value to false to maintain backward compatibility and one would have to change it to true to get the new feature. I believe that everywhere in the NiFi code we always use "required" for boolean properties (unless if the property should depend on flow files attributes but it would not make sense here in my opinion).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org