You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2022/05/10 18:26:28 UTC
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18516
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
IMPALA-10465: Bump Kudu version to 09a6c8833e
This patch bump KUDU_VERSION to 09a6c8833e to pick up Kudu commits
required for IMPALA-10465 work. These include:
* 948417a - [client] add DISALLOW_COPY_AND_ASSIGN() for a few classes
* 50395ff - [client] prohibit copying/assigning of ResourceMetrics
* 03f2668 - [client] KUDU-3365: Expose INSERT/UPDATE metrics in the Java API
* 0ddcaaa - [client] KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Testing:
- Build Impala using new kudu client code and pass core tests.
Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
---
M buildall.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/16/18516/1
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18516 )
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
Patch Set 3: Verified+1
This relation chain pass all test except a flaky minidump-test that is only recently fixed in IMPALA-11291.
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 May 2022 13:37:51 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18516 )
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 22:52:10 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18516 )
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
IMPALA-10465: Bump Kudu version to 09a6c8833e
This patch bump KUDU_VERSION to 09a6c8833e to pick up Kudu commits
required for IMPALA-10465 work. These include:
* 948417a - add DISALLOW_COPY_AND_ASSIGN() for a few classes
* 50395ff - prohibit copying/assigning of ResourceMetrics
* 03f2668 - KUDU-3365: Expose INSERT/UPDATE metrics in the Java API
* 0ddcaaa - KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Testing:
- Build Impala using new kudu client code and pass core tests.
Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Reviewed-on: http://gerrit.cloudera.org:8080/18516
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Riza Suminto <ri...@cloudera.com>
---
M buildall.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Riza Suminto: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18516 )
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18516/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18516/1//COMMIT_MSG@13
PS1, Line 13: xpose INSERT/UPDATE metrics in the Java API
nit: exceed line limit
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 21:58:33 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18516 )
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18516/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18516/1//COMMIT_MSG@13
PS1, Line 13: ERT/UPDATE metrics in the Java API
> nit: exceed line limit
Done
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 22:40:55 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18516 )
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
Patch Set 2: Code-Review+2
Carry +1 from Wenzhe
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 May 2022 15:28:52 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18516 )
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
Patch Set 3: Code-Review+2
Reapply +2
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 May 2022 15:35:55 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10465: Bump Kudu version to 09a6c8833e
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18516
to look at the new patch set (#2).
Change subject: IMPALA-10465: Bump Kudu version to 09a6c8833e
......................................................................
IMPALA-10465: Bump Kudu version to 09a6c8833e
This patch bump KUDU_VERSION to 09a6c8833e to pick up Kudu commits
required for IMPALA-10465 work. These include:
* 948417a - add DISALLOW_COPY_AND_ASSIGN() for a few classes
* 50395ff - prohibit copying/assigning of ResourceMetrics
* 03f2668 - KUDU-3365: Expose INSERT/UPDATE metrics in the Java API
* 0ddcaaa - KUDU-3351: Add ResourceMetricsPB into WriteResponsePB
Testing:
- Build Impala using new kudu client code and pass core tests.
Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
---
M buildall.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/16/18516/2
--
To view, visit http://gerrit.cloudera.org:8080/18516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6519c5e401fa083b97cc7c3e6630fa8261ee7e44
Gerrit-Change-Number: 18516
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>