You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cclauss <gi...@git.apache.org> on 2018/08/02 05:13:47 UTC
[GitHub] spark pull request #21959: [SPARK-23698] Define xrange() for Python 3 in dum...
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/21959
[SPARK-23698] Define xrange() for Python 3 in dumpdata_script.py
__xrange()__ was removed in Python 3 in favor of __range()__. This simple change removes three Undefined Names was originally suggested in #20838 which is currently mired in 50+ comments on unrelated modifications. @HyukjinKwon @holdenk
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cclauss/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21959.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21959
----
commit 15676ab875838cc99f71fab6f8618c886b294b1a
Author: cclauss <cc...@...>
Date: 2018-08-02T05:13:37Z
[SPARK-23698] Define xrange() for Python 3 in dumpdata_script.py
__xrange()__ was removed in Python 3 in favor of __range()__. This simple change removes three Undefined Names was originally suggested in #20838 which is currently mired in 50+ comments on unrelated modifications. @HyukjinKwon @holdenk
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21959: [SPARK-23698] Define xrange() for Python 3 in dumpdata_s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21959
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21959: [SPARK-23698] Define xrange() for Python 3 in dum...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss closed the pull request at:
https://github.com/apache/spark/pull/21959
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21959: [SPARK-23698] Define xrange() for Python 3 in dumpdata_s...
Posted by holdensmagicalunicorn <gi...@git.apache.org>.
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21959
@cclauss, thanks! I am a bot who has found some folks who might be able to help with the review:@pwendell and @HyukjinKwon
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21959: [SPARK-23698] Define xrange() for Python 3 in dumpdata_s...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21959
I am going to review and merge that one soon. It doesn't need to open multiple PRs.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21959: [SPARK-23698] Define xrange() for Python 3 in dumpdata_s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21959
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21959: [SPARK-23698] Define xrange() for Python 3 in dumpdata_s...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/21959
As it says in the commit message, these changes are already in #20838 but that PR has been open for 139 days and has 50+ comments. The only way that I seem to make progress is by opening separate PRs that are easier to review and approve.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21959: [SPARK-23698] Define xrange() for Python 3 in dumpdata_s...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21959
I think you can push the changes in https://github.com/apache/spark/pull/20838 and close this one. They look virtually the same issue.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21959: [SPARK-23698] Define xrange() for Python 3 in dumpdata_s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21959
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org