[GitHub] [incubator-hudi] n3nash commented on a change in pull request #674: MOR read query fixes and performance improvement

[GitBox <gi...@apache.org>]

n3nash commented on a change in pull request #674: MOR read query fixes and performance improvement
URL: https://github.com/apache/incubator-hudi/pull/674#discussion_r283465291
 
 

 ##########
 File path: hoodie-common/src/main/java/com/uber/hoodie/common/table/log/HoodieLogFormat.java
 ##########
 @@ -206,6 +219,13 @@ static WriterBuilder newWriterBuilder() {
     return new HoodieLogFileReader(fs, logFile, readerSchema, HoodieLogFileReader.DEFAULT_BUFFER_SIZE, false, false);
   }
 
+  static HoodieLogFormat.Reader newReader(FileSystem fs, HoodieLogFile logFile, Schema readerSchema, boolean
+      readBlockLazily, boolean reverseReader)
+      throws IOException {
+    return new HoodieLogFileReader(fs, logFile, readerSchema, HoodieLogFileReader.DEFAULT_BUFFER_SIZE,
 
 Review comment:
   Right now, we don't change it even for compaction jobs but it is exposed as a config..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services