You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/03 18:01:10 UTC
[GitHub] [camel-spring-boot] fg78nc opened a new pull request #222: Added Spring Boot XML DSL archetype
fg78nc opened a new pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] fg78nc edited a comment on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
fg78nc edited a comment on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721372214
I agree with you, it is not an idiomatic way for modern Spring Boot
development.
However please consider use cases where a user wants to migrate their Camel
application running on Fuse/Karaf to Spring Boot XML DSL.
On Tue, Nov 3, 2020 at 3:56 PM Claus Ibsen <no...@github.com> wrote:
> The old world with spring xml files (eg beans) is not something for spring
> boot. So we are not looking for a maven archetype that does this.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721369918>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEOCGNDCWDK3HWW73E6T6ALSOBU63ANCNFSM4TJCCD7Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] oscerd commented on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-722443695
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] oscerd commented on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721299680
This is a good question, we did some change after 3.4.x LTS. @davsclaus can you shed some light on XML routes in SB?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] fg78nc commented on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
fg78nc commented on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721340161
Oh, I see now.
I will try that. Where can I see an example of XML structure of Camel xml
route?
Is it just a route definition, similar to what can be dropped into ActiveMQ?
Also probably documentation has to be updated in several places, including
https://camel.apache.org/manual/latest/xml-configuration.html and
https://camel.apache.org/components/latest/spring-summary.html ?
On Tue, Nov 3, 2020 at 1:33 PM Claus Ibsen <no...@github.com> wrote:
> Its 2 different thing
>
> spring xml files with are ONLY spring that can load this via that spring
> boot @import <https://github.com/import> resource annotation.
>
> The xml routes is ONLY for Camel XML files which are xml snippets (not
> spring at all).
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721304197>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEOCGNFA6267F5ID2LCP6PTSOBEGHANCNFSM4TJCCD7Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721304197
Its 2 different thing
spring xml files with <beans> are ONLY spring that can load this via that spring boot @import resource annotation.
The xml routes is ONLY for Camel XML files which are <routes> xml snippets (not spring at all).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721369918
The old world with spring xml files (eg beans) is not something for spring boot. So we are not looking for a maven archetype that does this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] oscerd closed pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] fg78nc commented on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
fg78nc commented on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721372214
I agree with you, it is not an idiomatic way for modern Spring Boot
development.
However please consider use cases where a user wants to migrate their Camel
application running on Fuse/Karaf to Spring Boot Java DSL.
On Tue, Nov 3, 2020 at 3:56 PM Claus Ibsen <no...@github.com> wrote:
> The old world with spring xml files (eg beans) is not something for spring
> boot. So we are not looking for a maven archetype that does this.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721369918>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEOCGNDCWDK3HWW73E6T6ALSOBU63ANCNFSM4TJCCD7Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] fg78nc commented on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
fg78nc commented on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-722439593
@davsclaus @oscerd Please review and make a decision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] fg78nc commented on pull request #222: Added Spring Boot XML DSL archetype
Posted by GitBox <gi...@apache.org>.
fg78nc commented on pull request #222:
URL: https://github.com/apache/camel-spring-boot/pull/222#issuecomment-721293717
HI,
According to documentation Camel will pick up XML context/route definition
from the classpath.
However it did not work, unless I explicitly add @ImportResource.
It did not even work after adding camel.springboot.xml-routes to
application.properties.
Is it expected behavior?
On Tue, Nov 3, 2020 at 1:07 PM Andrea Cosentino <no...@github.com>
wrote:
> *@oscerd* approved this pull request.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-spring-boot/pull/222#pullrequestreview-522754989>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEOCGNDPLMLHV5SFEYAKAA3SOBBF5ANCNFSM4TJCCD7Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org