You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/12/27 16:08:00 UTC

[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #46: LOGCXX-324 Split up large syslog messages

rm5248 commented on a change in pull request #46:
URL: https://github.com/apache/logging-log4cxx/pull/46#discussion_r549130252



##########
File path: src/main/include/log4cxx/net/syslogappender.h
##########
@@ -136,6 +148,16 @@ class LOG4CXX_EXPORT SyslogAppender : public AppenderSkeleton
 			return facilityPrinting;
 		}
 
+		inline void setMaxMessagelength(int maxMessageLength1)

Review comment:
       * CamelCase fixed
   * maxMessageLength1 is a similar pattern to what is used in other places(see facilityprinting a few lines above).  I don't really like it either, but I don't want to have different coding styles if we can avoid it.
   * Personally, I prefer being a bit more verbose(message vs msg), especially when it's in a public API.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org