You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by gubaojian <gi...@git.apache.org> on 2018/02/08 04:02:29 UTC

[GitHub] incubator-weex pull request #1019: [WEEX-174][android] TemplateList Support ...

GitHub user gubaojian opened a pull request:

    https://github.com/apache/incubator-weex/pull/1019

     [WEEX-174][android] TemplateList Support Lifecycle and statefull component

     [WEEX-174][android] TemplateList Support Lifecycle and statefull component

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gubaojian/incubator-weex release-0.17-template-list-second

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1019
    
----
commit 20c293f4a9c4c14daa0deee19b9d9b9a4b73693b
Author: Zz <zh...@...>
Date:   2018-01-22T09:43:54Z

    #import <coreText/CoreText.h>   ==>   #import <CoreText/CoreText.h>

commit 886d859ab75ef892aad50506dace5818c06b66d2
Author: jianbai.gbj <ji...@...>
Date:   2017-12-20T07:07:01Z

    [WEEX-174][android] TemplateList Support Lifecycle and statefull component

commit 30ad3f6c0c13c635c0acdeb40a80f3064330248a
Author: jianbai.gbj <ji...@...>
Date:   2018-02-08T04:01:44Z

    Merge remote-tracking branch 'origin/master_apache' into release-0.17-template-list-second
    
    # Conflicts:
    #	android/sdk/src/main/java/com/taobao/weex/dom/action/UpdateAttributeAction.java

----


---

[GitHub] incubator-weex pull request #1019: [WEEX-174][android] TemplateList Support ...

Posted by gubaojian <gi...@git.apache.org>.
GitHub user gubaojian reopened a pull request:

    https://github.com/apache/incubator-weex/pull/1019

     [WEEX-174][android] TemplateList Support Lifecycle and statefull component

     [WEEX-174][android] TemplateList Support Lifecycle and statefull component

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gubaojian/incubator-weex release-0.17-template-list-second

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1019
    
----
commit 20c293f4a9c4c14daa0deee19b9d9b9a4b73693b
Author: Zz <zh...@...>
Date:   2018-01-22T09:43:54Z

    #import <coreText/CoreText.h>   ==>   #import <CoreText/CoreText.h>

commit 886d859ab75ef892aad50506dace5818c06b66d2
Author: jianbai.gbj <ji...@...>
Date:   2017-12-20T07:07:01Z

    [WEEX-174][android] TemplateList Support Lifecycle and statefull component

commit 30ad3f6c0c13c635c0acdeb40a80f3064330248a
Author: jianbai.gbj <ji...@...>
Date:   2018-02-08T04:01:44Z

    Merge remote-tracking branch 'origin/master_apache' into release-0.17-template-list-second
    
    # Conflicts:
    #	android/sdk/src/main/java/com/taobao/weex/dom/action/UpdateAttributeAction.java

----


---

[GitHub] incubator-weex pull request #1019: [WEEX-174][android] TemplateList Support ...

Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1019


---

[GitHub] incubator-weex pull request #1019: [WEEX-174][android] TemplateList Support ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1019


---

[GitHub] incubator-weex issue #1019: [WEEX-174][android] TemplateList Support Lifecyc...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1019
  
    
    <!--
      1 failure:  Code file android...
      6 warning:  No Changelog chan..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C...
      1 messages
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>Code file android/playground/app/src/main/java/com/alibaba/weex/extend/module/WXWsonTestModule.java does not have the copyright header.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXCell.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/WXEvent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/binding/Statements.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/template/WXRecyclerTemplateList.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---