[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2898: feat: remove operator range_read and range_reader API

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #2898:
URL: https://github.com/apache/incubator-opendal/pull/2898#discussion_r1300869521


##########
core/tests/behavior/read_only.rs:
##########
@@ -183,39 +181,9 @@ pub async fn test_read_only_read_full_with_special_chars(op: Operator) -> Result
     Ok(())
 }
 
-/// Read full content should match.
-pub async fn test_read_only_read_range(op: Operator) -> Result<()> {
-    let bs = op.range_read("normal_file", 1024..2048).await?;

Review Comment:
   We should replace with `read_with` instead of removing.



##########
core/src/types/operator/operator.rs:
##########
@@ -401,31 +400,6 @@ impl Operator {
         fut
     }
 
-    /// Read the specified range of path into a bytes.

Review Comment:
   Please add examples in `read_with` to show how to read with range.



##########
core/src/types/operator/operator.rs:
##########
@@ -445,28 +419,6 @@ impl Operator {
         self.reader_with(path).await
     }
 
-    /// Create a new reader which can read the specified range.

Review Comment:
   The same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org