You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/10/23 05:38:59 UTC

[jira] Created: (CASSANDRA-511) log abnormally long queries

log abnormally long queries
---------------------------

                 Key: CASSANDRA-511
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
             Project: Cassandra
          Issue Type: New Feature
            Reporter: Jonathan Ellis
            Priority: Minor
             Fix For: 0.5


add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-511) log abnormally long queries

Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Goffinet updated CASSANDRA-511:
-------------------------------------

    Attachment:     (was: 0001-Added-slow-log-query-insert-support.patch)

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-511) log abnormally long queries

Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Goffinet updated CASSANDRA-511:
-------------------------------------

    Attachment: 0001-Added-slow-log-query-insert-support.patch

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-511) log abnormally long queries

Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Goffinet updated CASSANDRA-511:
-------------------------------------

    Attachment: 0001-Added-slow-log-query-insert-support.patch

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-511) log abnormally long queries

Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Goffinet updated CASSANDRA-511:
-------------------------------------

    Attachment: 0001-Added-slow-log-query-insert-support.patch

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-511) log abnormally long queries

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-511.
--------------------------------------

    Resolution: Not A Problem
      Assignee:     (was: Chris Goffinet)

I haven't been able to come up with a scenario where having this would make a difference in being able to troubleshoot a problem, over the existing JMX metrics.  (Of course when it was created we had a lot less of those...)

Happy to reopen if someone thinks of one.

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Priority: Minor
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-511) log abnormally long queries

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781039#action_12781039 ] 

Stu Hood commented on CASSANDRA-511:
------------------------------------

+1
Looks good to me.

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-511) log abnormally long queries

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781061#action_12781061 ] 

Jonathan Ellis commented on CASSANDRA-511:
------------------------------------------

let's use LogMinDurationInsert and LogMinDurationGet as the configuration parameters, with negative value to disable either (no 3rd boolean).

long endTime should be declared where it is used (and should be renamed, since it's not the end time but the duration)

logging just the key might not be very helpful

logger.warn(duration + " ms for " + query) would be sufficiently verbose


> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-511) log abnormally long queries

Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776839#action_12776839 ] 

Chris Goffinet commented on CASSANDRA-511:
------------------------------------------

I've started work on this already. Should have patch soon.

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-511) log abnormally long queries

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-511:
-------------------------------------

    Fix Version/s:     (was: 0.5)

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-511) log abnormally long queries

Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Goffinet updated CASSANDRA-511:
-------------------------------------

    Attachment:     (was: 0001-Added-slow-log-query-insert-support.patch)

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 0001-Added-slow-log-query-insert-support.patch
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-511) log abnormally long queries

Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Goffinet reassigned CASSANDRA-511:
----------------------------------------

    Assignee: Chris Goffinet

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-511) log abnormally long queries

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775065#action_12775065 ] 

Jonathan Ellis commented on CASSANDRA-511:
------------------------------------------

the right place to log this imo is in storageproxy.  it should log the query (or insert) and the machine that was slow to reply.

> log abnormally long queries
> ---------------------------
>
>                 Key: CASSANDRA-511
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-511
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.5
>
>
> add an option to log queries taking longer than N ms (just the query, not the results)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.