You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/21 04:16:53 UTC
[GitHub] [iotdb] flashzxi opened a new pull request, #7380: [IOTDB-4470] Code generation to accelerate expression calculation
flashzxi opened a new pull request, #7380:
URL: https://github.com/apache/iotdb/pull/7380
At this stage, expression evaluation is based on the volcano model, and the evaluate function is called to the root node of the expression tree, and the tree will recursively call the evaluate function of the subtree to calculate the result of its own node. Such a procedure has a large number of virtual function calls, and each time needs to repeatedly call the function written by the corresponding type through the type of switch expression. The additional overhead of this process is enormous. It is hoped that the handwritten code of the calculation can be directly constructed according to the input expression to improve the execution efficiency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on pull request #7380: [IOTDB-4470] Code generation to accelerate expression calculation
Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on PR #7380:
URL: https://github.com/apache/iotdb/pull/7380#issuecomment-1290356320
We have tested the code with several experiments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on pull request #7380: [IOTDB-4470] Code generation to accelerate expression calculation
Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on PR #7380:
URL: https://github.com/apache/iotdb/pull/7380#issuecomment-1290357453
@flashzxi Please resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #7380: [IOTDB-4470] Code generation to accelerate expression calculation
Posted by GitBox <gi...@apache.org>.
xingtanzjr merged PR #7380:
URL: https://github.com/apache/iotdb/pull/7380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org