You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/11 18:12:30 UTC

[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8089: vfs/poll: Remove POLLFILE and POLLSOCK NuttX specific extension

xiaoxiang781216 opened a new pull request, #8089:
URL: https://github.com/apache/nuttx/pull/8089

   ## Summary
   
   Since after https://github.com/apache/nuttx/pull/8022, we don't need expose file_poll to user space anymore.
   
   ## Impact
   
   Remove the nuttx special extension
   
   ## Testing
   
   Pass CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] anchao merged pull request #8089: vfs/poll: Remove POLLFILE and POLLSOCK NuttX specific extension

Posted by GitBox <gi...@apache.org>.
anchao merged PR #8089:
URL: https://github.com/apache/nuttx/pull/8089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] acassis commented on a diff in pull request #8089: vfs/poll: Remove POLLFILE and POLLSOCK NuttX specific extension

Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #8089:
URL: https://github.com/apache/nuttx/pull/8089#discussion_r1068131615


##########
include/sys/poll.h:
##########
@@ -78,11 +78,6 @@
 #define POLLRDHUP    (0x10)  /* NuttX does not support shutdown(fd, SHUT_RD) */

Review Comment:
   Seeing this previous not supported comment, I have a question: how to implement this missing shutdown at libs/libc/net/lib_shutdown.c ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8089: vfs/poll: Remove POLLFILE and POLLSOCK NuttX specific extension

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8089:
URL: https://github.com/apache/nuttx/pull/8089#discussion_r1068181462


##########
include/sys/poll.h:
##########
@@ -78,11 +78,6 @@
 #define POLLRDHUP    (0x10)  /* NuttX does not support shutdown(fd, SHUT_RD) */

Review Comment:
   it's impossible, I think. The real implementation need move to net/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org