[GitHub] [jmeter] pmouawad commented on pull request #608: Bug 64553 When using Transaction Controller, send Bytes and Received Bytes are displayed as 0 in the influxdb(BackendListener)

[GitBox <gi...@apache.org>]

pmouawad commented on pull request #608:
URL: https://github.com/apache/jmeter/pull/608#issuecomment-674523648


   Hello Graham,
   Thanks for review.
   Feel free to improve the PR as the code is in JMeter branch.
   I Will not be able to do anything on it before september at least.
   
   Regards
   
   On Saturday, August 8, 2020, Graham Russell <no...@github.com>
   wrote:
   
   > *@ham1* commented on this pull request.
   > ------------------------------
   >
   > In src/components/src/test/java/org/apache/jmeter/visualizers/backend/
   > SamplerMetricTimedModeTest.java
   > <https://github.com/apache/jmeter/pull/608#discussion_r467487552>:
   >
   > > @@ -58,7 +58,7 @@ public void checkResetOkAndAllStats() throws Exception {
   >      public void checkResetKoAndAllStats() throws Exception {
   >
   >          SamplerMetric metric = new SamplerMetric();
   > -        metric.add(createSampleResult(false));
   > +        metric.add(createSampleResult(false), false);
   >
   > Worth adding at least a test for the true case?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/jmeter/pull/608#pullrequestreview-463817196>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAX3RKYSCP2XPD6W5QLHHMTR7WFEFANCNFSM4PWH4TIA>
   > .
   >
   
   
   -- 
   Cordialement
   Philippe M.
   Ubik-Ingenierie
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org