You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by IT CTO <go...@gmail.com> on 2015/07/30 16:27:16 UTC
Fwd: [incubator-zeppelin] Improve magic display system (#164)
So my question goes back to the mail list, what is the process in which I
get feedback about my pull request? Is it going to be merged?
Eran
---------- Forwarded message ---------
From: DuyHai Doan <do...@gmail.com>
Date: יום ה׳, 30 ביולי 2015, 14:25
Subject: Re: [incubator-zeppelin] Improve magic display system (#164)
To: IT CTO <go...@gmail.com>
Cc: DOAN DuyHai (JIRA) <ji...@apache.org>
Hello Eran
I think that the decision of which pull request is ready/good enough to be
merged into the trunk is decided by Apache Zeppelin PMC members.
On Thu, Jul 30, 2015 at 12:38 PM, IT CTO <go...@gmail.com> wrote:
> Hi,
> Since this is my first code contribution I was wondering what is the
> process to get this merged to the master branch?
> Can you help me?
> Eran
>
> ---------- Forwarded message ---------
> From: IT CTO <go...@gmail.com>
> Date: יום ג׳, 28 ביולי 2015, 07:10
> Subject: Re: [incubator-zeppelin] Improve magic display system (#164)
> To: apache/incubator-zeppelin <
> reply+0021fb8bd16161b97ac21af82b146da1313b30db2fb726d692cf0000000111cbaadd92a170ce021d7a3b@reply.github.com>,
> apache/incubator-zeppelin <in...@noreply.github.com>
>
>
> Can someone look at this one and merge it if possible?
> Eran
>
> בתאריך שבת, 25 ביולי 2015, 22:51 מאת Felix Cheung <
> notifications@github.com>:
>
>> In
>> zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterResult.java
>> <https://github.com/apache/incubator-zeppelin/pull/164#discussion_r35486267>
>> :
>>
>> > - if (msg.startsWith(magic + " ") || msg.startsWith(magic + "\n")) {
>> > - int magicLength = magic.length() + 1;
>> > - if (msg.length() > magicLength) {
>> > - return msg.substring(magicLength);
>> > - } else {
>> > - return "";
>> > - }
>> > - }
>> > + Type[] types = type.values();
>> > + TreeMap<Integer, Type> typesLastIndexInMsg = buildIndexMap(msg);
>> > + if (typesLastIndexInMsg.size() == 0) {
>> > + return msg;
>> > + } else {
>> > + Map.Entry<Integer, Type> lastType = typesLastIndexInMsg.lastEntry();
>> > + int magicLength = lastType.getValue().name().length() + 1; //add 1 for the %
>> > + int subStringPos = magicLength + lastType.getKey() + 1; // 1 for the last \w after magic
>>
>> Cool!!
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/apache/incubator-zeppelin/pull/164/files#r35486267>.
>>
>
Re: Fwd: [incubator-zeppelin] Improve magic display system (#164)
Posted by Corneau Damien <co...@gmail.com>.
Yeah, if its not merged, people who are just getting Zeppelin from master
obviously wouldn't have the changes.
Usually people interested in the issue are testing it, as well as some PPMC
of the project in order to merge. It can sometimes take a bit of time for
us to review and merge a PR since we have a day job, review multiple PR and
also so some work on Zeppelin.
If the PR is finished, we like to have a message in the PR like: 'Ready for
Merge'. Or even a mention (@), so that we take a last look.
Thanks, but how is that get tested if it is only in my fork? As much as I
understand, if someone fetch from upstream he will not get the changes
until merge. Right?
Eran
בתאריך יום ה׳, 30 ביולי 2015, 18:26 מאת Corneau Damien <corneadoug@gmail.com
>:
> I guess process would be:
> PR tested for some time to make sure there is no problems (with different
> queries and existing notebooks).
> Then if there is nothing wrong and no more modifications to do, merging
> On Jul 30, 2015 23:28, "IT CTO" <go...@gmail.com> wrote:
>
> > So my question goes back to the mail list, what is the process in which
I
> > get feedback about my pull request? Is it going to be merged?
> > Eran
> >
> > ---------- Forwarded message ---------
> > From: DuyHai Doan <do...@gmail.com>
> > Date: יום ה׳, 30 ביולי 2015, 14:25
> > Subject: Re: [incubator-zeppelin] Improve magic display system (#164)
> > To: IT CTO <go...@gmail.com>
> > Cc: DOAN DuyHai (JIRA) <ji...@apache.org>
> >
> >
> > Hello Eran
> >
> > I think that the decision of which pull request is ready/good enough to
> be
> > merged into the trunk is decided by Apache Zeppelin PMC members.
> >
> > On Thu, Jul 30, 2015 at 12:38 PM, IT CTO <go...@gmail.com> wrote:
> >
> > > Hi,
> > > Since this is my first code contribution I was wondering what is the
> > > process to get this merged to the master branch?
> > > Can you help me?
> > > Eran
> > >
> > > ---------- Forwarded message ---------
> > > From: IT CTO <go...@gmail.com>
> > > Date: יום ג׳, 28 ביולי 2015, 07:10
> > > Subject: Re: [incubator-zeppelin] Improve magic display system (#164)
> > > To: apache/incubator-zeppelin <
> > >
> >
>
reply+0021fb8bd16161b97ac21af82b146da1313b30db2fb726d692cf0000000111cbaadd92a170ce021d7a3b@reply.github.com
> > >,
> > > apache/incubator-zeppelin <in...@noreply.github.com>
> > >
> > >
> > > Can someone look at this one and merge it if possible?
> > > Eran
> > >
> > > בתאריך שבת, 25 ביולי 2015, 22:51 מאת Felix Cheung <
> > > notifications@github.com>:
> > >
> > >> In
> > >>
> >
>
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterResult.java
> > >> <
> >
> https://github.com/apache/incubator-zeppelin/pull/164#discussion_r35486267
> > >
> > >> :
> > >>
> > >> > - if (msg.startsWith(magic + " ") || msg.startsWith(magic +
> > "\n")) {
> > >> > - int magicLength = magic.length() + 1;
> > >> > - if (msg.length() > magicLength) {
> > >> > - return msg.substring(magicLength);
> > >> > - } else {
> > >> > - return "";
> > >> > - }
> > >> > - }
> > >> > + Type[] types = type.values();
> > >> > + TreeMap<Integer, Type> typesLastIndexInMsg =
> buildIndexMap(msg);
> > >> > + if (typesLastIndexInMsg.size() == 0) {
> > >> > + return msg;
> > >> > + } else {
> > >> > + Map.Entry<Integer, Type> lastType =
> > typesLastIndexInMsg.lastEntry();
> > >> > + int magicLength = lastType.getValue().name().length() + 1;
> > //add 1 for the %
> > >> > + int subStringPos = magicLength + lastType.getKey() + 1; // 1
> > for the last \w after magic
> > >>
> > >> Cool!!
> > >>
> > >> —
> > >> Reply to this email directly or view it on GitHub
> > >> <
> https://github.com/apache/incubator-zeppelin/pull/164/files#r35486267
> > >.
> > >>
> > >
> >
>
Re: Fwd: [incubator-zeppelin] Improve magic display system (#164)
Posted by IT CTO <go...@gmail.com>.
Thanks, but how is that get tested if it is only in my fork? As much as I
understand, if someone fetch from upstream he will not get the changes
until merge. Right?
Eran
בתאריך יום ה׳, 30 ביולי 2015, 18:26 מאת Corneau Damien <corneadoug@gmail.com
>:
> I guess process would be:
> PR tested for some time to make sure there is no problems (with different
> queries and existing notebooks).
> Then if there is nothing wrong and no more modifications to do, merging
> On Jul 30, 2015 23:28, "IT CTO" <go...@gmail.com> wrote:
>
> > So my question goes back to the mail list, what is the process in which I
> > get feedback about my pull request? Is it going to be merged?
> > Eran
> >
> > ---------- Forwarded message ---------
> > From: DuyHai Doan <do...@gmail.com>
> > Date: יום ה׳, 30 ביולי 2015, 14:25
> > Subject: Re: [incubator-zeppelin] Improve magic display system (#164)
> > To: IT CTO <go...@gmail.com>
> > Cc: DOAN DuyHai (JIRA) <ji...@apache.org>
> >
> >
> > Hello Eran
> >
> > I think that the decision of which pull request is ready/good enough to
> be
> > merged into the trunk is decided by Apache Zeppelin PMC members.
> >
> > On Thu, Jul 30, 2015 at 12:38 PM, IT CTO <go...@gmail.com> wrote:
> >
> > > Hi,
> > > Since this is my first code contribution I was wondering what is the
> > > process to get this merged to the master branch?
> > > Can you help me?
> > > Eran
> > >
> > > ---------- Forwarded message ---------
> > > From: IT CTO <go...@gmail.com>
> > > Date: יום ג׳, 28 ביולי 2015, 07:10
> > > Subject: Re: [incubator-zeppelin] Improve magic display system (#164)
> > > To: apache/incubator-zeppelin <
> > >
> >
> reply+0021fb8bd16161b97ac21af82b146da1313b30db2fb726d692cf0000000111cbaadd92a170ce021d7a3b@reply.github.com
> > >,
> > > apache/incubator-zeppelin <in...@noreply.github.com>
> > >
> > >
> > > Can someone look at this one and merge it if possible?
> > > Eran
> > >
> > > בתאריך שבת, 25 ביולי 2015, 22:51 מאת Felix Cheung <
> > > notifications@github.com>:
> > >
> > >> In
> > >>
> >
> zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterResult.java
> > >> <
> >
> https://github.com/apache/incubator-zeppelin/pull/164#discussion_r35486267
> > >
> > >> :
> > >>
> > >> > - if (msg.startsWith(magic + " ") || msg.startsWith(magic +
> > "\n")) {
> > >> > - int magicLength = magic.length() + 1;
> > >> > - if (msg.length() > magicLength) {
> > >> > - return msg.substring(magicLength);
> > >> > - } else {
> > >> > - return "";
> > >> > - }
> > >> > - }
> > >> > + Type[] types = type.values();
> > >> > + TreeMap<Integer, Type> typesLastIndexInMsg =
> buildIndexMap(msg);
> > >> > + if (typesLastIndexInMsg.size() == 0) {
> > >> > + return msg;
> > >> > + } else {
> > >> > + Map.Entry<Integer, Type> lastType =
> > typesLastIndexInMsg.lastEntry();
> > >> > + int magicLength = lastType.getValue().name().length() + 1;
> > //add 1 for the %
> > >> > + int subStringPos = magicLength + lastType.getKey() + 1; // 1
> > for the last \w after magic
> > >>
> > >> Cool!!
> > >>
> > >> —
> > >> Reply to this email directly or view it on GitHub
> > >> <
> https://github.com/apache/incubator-zeppelin/pull/164/files#r35486267
> > >.
> > >>
> > >
> >
>
Re: Fwd: [incubator-zeppelin] Improve magic display system (#164)
Posted by Corneau Damien <co...@gmail.com>.
I guess process would be:
PR tested for some time to make sure there is no problems (with different
queries and existing notebooks).
Then if there is nothing wrong and no more modifications to do, merging
On Jul 30, 2015 23:28, "IT CTO" <go...@gmail.com> wrote:
> So my question goes back to the mail list, what is the process in which I
> get feedback about my pull request? Is it going to be merged?
> Eran
>
> ---------- Forwarded message ---------
> From: DuyHai Doan <do...@gmail.com>
> Date: יום ה׳, 30 ביולי 2015, 14:25
> Subject: Re: [incubator-zeppelin] Improve magic display system (#164)
> To: IT CTO <go...@gmail.com>
> Cc: DOAN DuyHai (JIRA) <ji...@apache.org>
>
>
> Hello Eran
>
> I think that the decision of which pull request is ready/good enough to be
> merged into the trunk is decided by Apache Zeppelin PMC members.
>
> On Thu, Jul 30, 2015 at 12:38 PM, IT CTO <go...@gmail.com> wrote:
>
> > Hi,
> > Since this is my first code contribution I was wondering what is the
> > process to get this merged to the master branch?
> > Can you help me?
> > Eran
> >
> > ---------- Forwarded message ---------
> > From: IT CTO <go...@gmail.com>
> > Date: יום ג׳, 28 ביולי 2015, 07:10
> > Subject: Re: [incubator-zeppelin] Improve magic display system (#164)
> > To: apache/incubator-zeppelin <
> >
> reply+0021fb8bd16161b97ac21af82b146da1313b30db2fb726d692cf0000000111cbaadd92a170ce021d7a3b@reply.github.com
> >,
> > apache/incubator-zeppelin <in...@noreply.github.com>
> >
> >
> > Can someone look at this one and merge it if possible?
> > Eran
> >
> > בתאריך שבת, 25 ביולי 2015, 22:51 מאת Felix Cheung <
> > notifications@github.com>:
> >
> >> In
> >>
> zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterResult.java
> >> <
> https://github.com/apache/incubator-zeppelin/pull/164#discussion_r35486267
> >
> >> :
> >>
> >> > - if (msg.startsWith(magic + " ") || msg.startsWith(magic +
> "\n")) {
> >> > - int magicLength = magic.length() + 1;
> >> > - if (msg.length() > magicLength) {
> >> > - return msg.substring(magicLength);
> >> > - } else {
> >> > - return "";
> >> > - }
> >> > - }
> >> > + Type[] types = type.values();
> >> > + TreeMap<Integer, Type> typesLastIndexInMsg = buildIndexMap(msg);
> >> > + if (typesLastIndexInMsg.size() == 0) {
> >> > + return msg;
> >> > + } else {
> >> > + Map.Entry<Integer, Type> lastType =
> typesLastIndexInMsg.lastEntry();
> >> > + int magicLength = lastType.getValue().name().length() + 1;
> //add 1 for the %
> >> > + int subStringPos = magicLength + lastType.getKey() + 1; // 1
> for the last \w after magic
> >>
> >> Cool!!
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <https://github.com/apache/incubator-zeppelin/pull/164/files#r35486267
> >.
> >>
> >
>