You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/28 16:49:56 UTC

[GitHub] [flink] blublinsky edited a comment on pull request #14281: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes setup

blublinsky edited a comment on pull request #14281:
URL: https://github.com/apache/flink/pull/14281#issuecomment-751781652


   @wangyang0918, thanks for the comment
   "parsing the KubernetesOwnerReference is not the ability of KubernetesJobManagerFactory". I agree with this and can move this to KubernetesJobManagerParameters. this will clean up the code.
   "Second, we already have the mechanism to parse the structured string to a map" - but unlike environment, owner reference is not really a map - its a list of parameters - does it make sense to convert this to the map, or positional list is good enough?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org