You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/06/04 07:15:24 UTC
[jira] [Created] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Sijie Guo created BOOKKEEPER-283:
------------------------------------
Summary: Improve Hedwig Console to use Hedwig Metadata Manager.
Key: BOOKKEEPER-283
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
Project: Bookkeeper
Issue Type: Sub-task
Components: hedwig-server
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.2.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-283:
---------------------------------
Attachment: BOOKKEEPER-283.diff
attach a new patch rebased to latest trunk after BOOKKEEPER-250 and BOOKKEEPER-259 in.
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436746#comment-13436746 ]
Hudson commented on BOOKKEEPER-283:
-----------------------------------
Integrated in bookkeeper-trunk #653 (See [https://builds.apache.org/job/bookkeeper-trunk/653/])
BOOKKEEPER-283: Improve Hedwig Console to use Hedwig Metadata Manager. (sijie via ivank) (Revision 1374265)
Result = FAILURE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/JLineHedwigCompletor.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/meta/MetadataManagerFactory.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/meta/ZkMetadataManagerFactory.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/topics/HubLoad.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestMetadataManagerFactory.java
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436615#comment-13436615 ]
Ivan Kelly commented on BOOKKEEPER-283:
---------------------------------------
- Why are you returning ByteString from getTopics() source data is always String and the caller converts it back into String straight away anyhow.
- pressKeyToContinue should accept any key to continue, as there is only one possible continuation. I haven't run it, but from the look of it, it would require a Y<Return> to continue.
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-283:
---------------------------------
Attachment: BOOKKEEPER-283.diff
attach a patch to improve hedwig console to use hedwig metadata manager introduced in BOOKKEEPER-250 and BOOKKEEPER-259.
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-283:
---------------------------------
Attachment: BOOKKEEPER-283.diff
attach a new patch to address Ivan's comments, leverage ConsoleReader in console mode and Terminal in non-console mode.
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-283:
---------------------------------
Attachment: BOOKKEEPER-283.diff_v2
new patch similar as BOOKKEEPER-203, to remove zookeeper integer version dependency.
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436621#comment-13436621 ]
Ivan Kelly commented on BOOKKEEPER-283:
---------------------------------------
actually, there's no clean way to read a character unbuffered from the console in java, so maybe pressKeyToContinue should be "Press <Return> to continue"
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436639#comment-13436639 ]
Ivan Kelly commented on BOOKKEEPER-283:
---------------------------------------
In fact, you can use jline.Terminal if available to make both <Return> and Q as single keystroke.
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436638#comment-13436638 ]
Ivan Kelly commented on BOOKKEEPER-283:
---------------------------------------
{quote}As all the hedwig uses ByteString for topic name, so we need to stick to the style.{quote}
Sure.
{quote}it did accept any key to continue. just when user press 'y' or 'Y', it continues showing next topic list. pressing other key would stop showing next topic list.{quote}
I think it would be better to have "Press <Return> for more, or Q to cancel". As listing more will be the most common case, it would be good for it to be only one keystroke.
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-283) Improve Hedwig Console to use
Hedwig Metadata Manager.
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436635#comment-13436635 ]
Sijie Guo commented on BOOKKEEPER-283:
--------------------------------------
> Why are you returning ByteString from getTopics() source data is always String and the caller converts it back into String straight away anyhow.
As all the hedwig uses ByteString for topic name, so we need to stick to the style.
> pressKeyToContinue should accept any key to continue, as there is only one possible continuation.
it did accept any key to continue. just when user press 'y' or 'Y', it continues showing next topic list. pressing other key would stop showing next topic list.
> Improve Hedwig Console to use Hedwig Metadata Manager.
> ------------------------------------------------------
>
> Key: BOOKKEEPER-283
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-283
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-283.diff, BOOKKEEPER-283.diff, BOOKKEEPER-283.diff_v2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira