[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #304: [FLINK-28445] Support operator configuration from multiple configmaps

[GitBox <gi...@apache.org>]

morhidi commented on code in PR #304:
URL: https://github.com/apache/flink-kubernetes-operator/pull/304#discussion_r916590783


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -211,11 +212,28 @@ protected Cache<Key, Configuration> getCache() {
         return cache;
     }
 
+    private static Configuration loadGlobalConfiguration() {
+        return loadGlobalConfiguration(EnvUtils.get(EnvUtils.ENV_DYNAMIC_CONF_DIR));
+    }
+
+    @VisibleForTesting
+    protected static Configuration loadGlobalConfiguration(Optional<String> dynamicConfigDir) {
+        if (dynamicConfigDir.isPresent()) {
+            Configuration dynamicConfigs =
+                    GlobalConfiguration.loadConfiguration(dynamicConfigDir.get());
+            LOG.debug(
+                    "Loading default configuration with overrides from " + dynamicConfigDir.get());
+            return GlobalConfiguration.loadConfiguration(dynamicConfigs);
+        }

Review Comment:
   makes sense, will use `override` over `dynamic`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org