You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/02 12:38:30 UTC
[GitHub] [beam] TobKed opened a new pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
TobKed opened a new pull request #12166:
URL: https://github.com/apache/beam/pull/12166
We need to Cancel builds to PR too.
similar change in Apache Airflow
https://github.com/apache/airflow/pull/9513
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | --- | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
Posted by GitBox <gi...@apache.org>.
aaltay commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r450559375
##########
File path: .github/workflows/cancel.yml
##########
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review comment:
When does a 'push' event and a 'pull_request' event happen?
AFAIK, no tests are running before a PR is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
Posted by GitBox <gi...@apache.org>.
aaltay commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r451063093
##########
File path: .github/workflows/cancel.yml
##########
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review comment:
> e.g. new merge commit on master appear. So it is possible to run rests without PR.
I do not understand how/when this would happen. Because we do not allow direct pushes to master. And if it is already in master a PR would not be helpful. Maybe this example applies to release branches?
Overall, I am fine with the change. It is ok to cancel tests when a new PR is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #12166:
URL: https://github.com/apache/beam/pull/12166#issuecomment-653653942
R: @aaltay @kamilwu @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r452297033
##########
File path: .github/workflows/cancel.yml
##########
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review comment:
I wasn't aware that direct push to master is not allowed however merge commits which appear on master also trigger _push_ event:
Here you can check filtered wheels builds for _push_ event on _master_:
https://github.com/apache/beam/actions?query=event%3Apush+branch%3Amaster+workflow%3A%22Build+python+wheels%22
and example of _push_ events similar on the release branch `release-2.23.0`:
https://github.com/apache/beam/actions?query=event%3Apush+branch%3Arelease-2.23.0
In comparison here are "_pull request_" events triggered on the various branches:
https://github.com/apache/beam/actions?query=event%3Apull_request
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
Posted by GitBox <gi...@apache.org>.
aaltay merged pull request #12166:
URL: https://github.com/apache/beam/pull/12166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TobKed commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r450702973
##########
File path: .github/workflows/cancel.yml
##########
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review comment:
In relation to : https://github.com/apache/beam/blob/master/.github/workflows/build_wheels.yml#L21
Push: when new commits are pushed to the specified branches. e.g. new merge commit on master appear. So it is possible to run rests without PR.
Pull request: when PR to specified branch is created and then again when new commits appear in the PR.
It is not critical since PR builds do not delete/upload anything to the GCS (push builds do), but I think it would be convenient to decrease queue by introducing such a small change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on a change in pull request #12166: [BEAM-10404] Cancel queued/running GitHub Action builds on second push to PR
Posted by GitBox <gi...@apache.org>.
aaltay commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r451063093
##########
File path: .github/workflows/cancel.yml
##########
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review comment:
> e.g. new merge commit on master appear. So it is possible to run rests without PR.
I do not understand how/when this would happen. Because we do not allow direct pushes to master. And if it is already in master a PR would not be helpful. Maybe this example applies to release branches?
Overall, I am fine with the change. It is ok to cancel tests when a new PR is created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org