[GitHub] [james-project] chibenwa commented on a diff in pull request #1338: JAMES-3754 Storage layer support for IMAP save date extension

[GitBox <gi...@apache.org>]

chibenwa commented on code in PR #1338:
URL: https://github.com/apache/james-project/pull/1338#discussion_r1034593350


##########
mailbox/api/src/main/java/org/apache/james/mailbox/MessageManager.java:
##########
@@ -232,7 +232,7 @@ public final int hashCode() {
      * @throws MailboxException
      *             when message cannot be appended
      */
-    AppendResult appendMessage(InputStream msgIn, Date internalDate, MailboxSession mailboxSession, boolean isRecent, Flags flags) throws MailboxException;
+    AppendResult appendMessage(InputStream msgIn, Date internalDate, Date saveDate, MailboxSession mailboxSession, boolean isRecent, Flags flags) throws MailboxException;

Review Comment:
   IMO the `MessageManager` and `MessageIdManager` are responsible of setting the saveDate.
   
   We should not leak it on this API



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org