You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/02/22 22:57:14 UTC
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/
-----------------------------------------------------------
(Updated Feb. 22, 2018, 10:57 p.m.)
Review request for mesos and Andrei Budnik.
Summary (updated)
-----------------
Added test for a hung 'docker inspect' during container pull.
Repository: mesos
Description (updated)
-------
Added test for a hung 'docker inspect' during container pull.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
Diff: https://reviews.apache.org/r/65750/diff/2/
Changes: https://reviews.apache.org/r/65750/diff/1-2/
Testing (updated)
-------
sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
Thanks,
Greg Mann
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Feb. 23, 2018, 6:12 p.m., Gilbert Song wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 5251-5258 (patched)
> > <https://reviews.apache.org/r/65750/diff/2/?file=1963502#file1963502line5251>
> >
> > Instead of following the style in this file, could we do `createTask()`?
I used the `createTask` helper, but since we don't have an overload which accepts a ContainerInfo I still had to modify the TaskInfo. We could add a new overload in the future perhaps.
> On Feb. 23, 2018, 6:12 p.m., Gilbert Song wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 5284-5285 (patched)
> > <https://reviews.apache.org/r/65750/diff/2/?file=1963502#file1963502line5284>
> >
> > Could we also verify that the statusFailed's reason is due to TIMEOUT?
The reason is actually due to container launch failure - I think this makes sense, since although the executor registration timeout triggers the status update, the container was never launched successfully. I added an expectation to check this.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198195
-----------------------------------------------------------
On Feb. 23, 2018, 10:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 10:41 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for a hung 'docker inspect' during container pull.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
>
>
> Diff: https://reviews.apache.org/r/65750/diff/3/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198195
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5188 (patched)
<https://reviews.apache.org/r/65750/#comment278302>
s/ROOT_DOCKER_InspectDuringPull/ROOT_DOCKER_InspectHungDuringPull/g?
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5251-5258 (patched)
<https://reviews.apache.org/r/65750/#comment278303>
Instead of following the style in this file, could we do `createTask()`?
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5284-5285 (patched)
<https://reviews.apache.org/r/65750/#comment278304>
Could we also verify that the statusFailed's reason is due to TIMEOUT?
- Gilbert Song
On Feb. 22, 2018, 3:10 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 3:10 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'HungDockerTest.ROOT_DOCKER_InspectDuringPull'
> verifies that the Mesos agent will send a TASK_FAILED
> update for a Docker task which fails because the executor
> registration timeout elapses while the container is stuck
> in the PULLING state due to a hung 'docker inspect' call.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
>
>
> Diff: https://reviews.apache.org/r/65750/diff/2/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198233
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65786, 65787, 65751, 65750]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 23, 2018, 11:26 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 11:26 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for a hung 'docker inspect' during container pull.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
>
>
> Diff: https://reviews.apache.org/r/65750/diff/4/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/
-----------------------------------------------------------
(Updated Feb. 23, 2018, 11:26 p.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
Repository: mesos
Description
-------
Added test for a hung 'docker inspect' during container pull.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
Diff: https://reviews.apache.org/r/65750/diff/4/
Changes: https://reviews.apache.org/r/65750/diff/3-4/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
Thanks,
Greg Mann
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198226
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5259-5267 (patched)
<https://reviews.apache.org/r/65750/#comment278339>
Should we just do:
```
TaskInfo task = createTask(
offer.slave_id(),
offer.resources(),
SLEEP_COMMAND(1000));
```
- Gilbert Song
On Feb. 23, 2018, 2:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 2:41 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for a hung 'docker inspect' during container pull.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
>
>
> Diff: https://reviews.apache.org/r/65750/diff/3/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198218
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 65786.
Failed command: `python.exe .\support\apply-reviews.py -n -r 65786`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65750
Relevant logs:
- [apply-review-65786-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65750/logs/apply-review-65786-stdout.log):
```
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: unable to auto-detect email address (got 'SYSTEM@build-srv-04.(none)')
```
- Mesos Reviewbot Windows
On Feb. 23, 2018, 10:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 10:41 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for a hung 'docker inspect' during container pull.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
>
>
> Diff: https://reviews.apache.org/r/65750/diff/3/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/
-----------------------------------------------------------
(Updated Feb. 23, 2018, 10:41 p.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
Repository: mesos
Description (updated)
-------
Added test for a hung 'docker inspect' during container pull.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
Diff: https://reviews.apache.org/r/65750/diff/3/
Changes: https://reviews.apache.org/r/65750/diff/2-3/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
Thanks,
Greg Mann
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198186
-----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5193-5195 (patched)
<https://reviews.apache.org/r/65750/#comment278294>
Can `CreateSlaveFlags` be overridden in `HungDockerTest`?
- Andrei Budnik
On Feb. 22, 2018, 11:10 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 11:10 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'HungDockerTest.ROOT_DOCKER_InspectDuringPull'
> verifies that the Mesos agent will send a TASK_FAILED
> update for a Docker task which fails because the executor
> registration timeout elapses while the container is stuck
> in the PULLING state due to a hung 'docker inspect' call.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
>
>
> Diff: https://reviews.apache.org/r/65750/diff/2/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198152
-----------------------------------------------------------
Bad patch!
Reviews applied: [65750, 65751, 65743, 65683]
Failed command: python support/apply-reviews.py -n -r 65683
Error:
2018-02-22 23:50:16 URL:https://reviews.apache.org/r/65683/diff/raw/ [2168/2168] -> "65683.patch" [1]
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/21736/console
- Mesos Reviewbot
On Feb. 22, 2018, 3:10 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 3:10 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'HungDockerTest.ROOT_DOCKER_InspectDuringPull'
> verifies that the Mesos agent will send a TASK_FAILED
> update for a Docker task which fails because the executor
> registration timeout elapses while the container is stuck
> in the PULLING state due to a hung 'docker inspect' call.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
>
>
> Diff: https://reviews.apache.org/r/65750/diff/2/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/
-----------------------------------------------------------
(Updated Feb. 22, 2018, 11:10 p.m.)
Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
Repository: mesos
Description (updated)
-------
The new test 'HungDockerTest.ROOT_DOCKER_InspectDuringPull'
verifies that the Mesos agent will send a TASK_FAILED
update for a Docker task which fails because the executor
registration timeout elapses while the container is stuck
in the PULLING state due to a hung 'docker inspect' call.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
Diff: https://reviews.apache.org/r/65750/diff/2/
Testing
-------
sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
Thanks,
Greg Mann
Re: Review Request 65750: Added test for a hung 'docker inspect'
during container pull.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198146
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 65683.
Failed command: `python.exe .\support\apply-reviews.py -n -r 65683`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65750
Relevant logs:
- [apply-review-65683-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65750/logs/apply-review-65683-stdout.log):
```
error: patch failed: src/docker/docker.cpp:1308
error: src/docker/docker.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Feb. 22, 2018, 10:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 10:57 p.m.)
>
>
> Review request for mesos and Andrei Budnik.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for a hung 'docker inspect' during container pull.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
>
>
> Diff: https://reviews.apache.org/r/65750/diff/2/
>
>
> Testing
> -------
>
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
>
>
> Thanks,
>
> Greg Mann
>
>