[GitHub] [flink-kubernetes-operator] HuangZhenQiu commented on a diff in pull request #561: [FLINK-30609] Add ephemeral storage to CRD

["HuangZhenQiu (via GitHub)" <gi...@apache.org>]

HuangZhenQiu commented on code in PR #561:
URL: https://github.com/apache/flink-kubernetes-operator/pull/561#discussion_r1156777913


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -366,6 +368,18 @@ private Optional<String> validateResources(String component, Resource resource)
             return Optional.of(component + " resource memory parse error: " + iae.getMessage());
         }
 
+        String storage = resource.getEphemeralStorage();

Review Comment:
   Got catch. Thanks!



##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -409,15 +419,44 @@ private static void setPodTemplate(
             effectiveConfig.setString(
                     podConfigOption,
                     createTempFile(
-                            mergePodTemplates(
-                                    basicPod,
-                                    appendPod,
-                                    effectiveConfig.get(
-                                            KubernetesOperatorConfigOptions
-                                                    .POD_TEMPLATE_MERGE_BY_NAME))));
+                            applyResourceToPodTemplate(
+                                    mergePodTemplates(

Review Comment:
   Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org