You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2017/12/06 15:30:34 UTC
[GitHub] carbondata pull request #1627: [CARBONDATA-1759]make visibility of segments ...
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/1627
[CARBONDATA-1759]make visibility of segments as false eventhough file is not present To take care show segments after clean files operation
make visibility of segments as false eventhough file is not present To take care show segments after clean files operation
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
NA
- [X] Any backward compatibility impacted?
NA
- [X] Document update required?
- [X] Testing done
test cases needs to be added
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/akashrn5/incubator-carbondata cleanfiles
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1627.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1627
----
----
---
[GitHub] carbondata pull request #1627: [CARBONDATA-1759]make visibility of segments ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1627
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1627
LGTM
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1852/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/624/
---
[GitHub] carbondata pull request #1627: [CARBONDATA-1759]make visibility of segments ...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1627#discussion_r156275385
--- Diff: processing/src/main/java/org/apache/carbondata/processing/util/DeleteLoadFolders.java ---
@@ -122,26 +122,21 @@ private static boolean checkIfLoadCanBeDeleted(LoadMetadataDetails oneLoad,
return false;
}
- public static boolean deleteLoadFoldersFromFileSystem(
+ public static void deleteLoadFoldersFromFileSystem(
AbsoluteTableIdentifier absoluteTableIdentifier, boolean isForceDelete,
LoadMetadataDetails[] details) {
- boolean isDeleted = false;
if (details != null && details.length != 0) {
for (LoadMetadataDetails oneLoad : details) {
if (checkIfLoadCanBeDeleted(oneLoad, isForceDelete)) {
String path = getSegmentPath(absoluteTableIdentifier, 0, oneLoad);
- boolean deletionStatus = physicalFactAndMeasureMetadataDeletion(path);
- if (deletionStatus) {
- isDeleted = true;
- oneLoad.setVisibility("false");
- LOGGER.info("Info: Deleted the load " + oneLoad.getLoadName());
- }
+ physicalFactAndMeasureMetadataDeletion(path);
--- End diff --
While handling deletion in this method return true in case file does not exist and add a warning logger. As we dont have any other mechanism for clean up it will be good if we keep all the remaining code same and only set the status as true in case of non existence of file
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1777/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1627
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2166/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/518/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/611/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1887/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/655/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1627
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2151/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1839/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1627
retest sdv please
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1627
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2212/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:
https://github.com/apache/carbondata/pull/1627
retest this please
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1627
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/587/
---
[GitHub] carbondata issue #1627: [CARBONDATA-1759]make visibility of segments as fals...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1627
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2234/
---