You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ydder <gi...@git.apache.org> on 2015/05/27 10:31:13 UTC
[GitHub] cloudstack pull request: Dhcp dns offload feature code changes
GitHub user ydder opened a pull request:
https://github.com/apache/cloudstack/pull/315
Dhcp dns offload feature code changes
Added dhcp dns offload feature code changes in this patch.
The changes added in this patch are for only xenserver.
While this pull request is in review process, I will work on adding the changes for kvm and vmware and the vm scripts.
User can test the below functionality
1. Create shared network offering without any services.
2. Create shared network with the above offering.
3. Deploy VM in this shared network.
4. VM will get deployed and config drive iso get attached to VM.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ydder/cloudstack dhcpdnsoffload
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit 2b7ea09d989bd673df0087730a7184935b49f543
Author: Jayapal <ja...@apache.org>
Date: 2015-05-13T12:13:04Z
CLOUDSTACK-8324: shared network without any service
commit 0a9f58850f1406d78f95f5cfe37788081f3e30f2
Author: Jayapal <ja...@apache.org>
Date: 2015-05-19T11:42:33Z
CLOUDSTACK-8324: Skip ip allocation for external dhcp
commit c0592e5372714b0a438cdde1341feeba0f6dfa00
Author: Jayapal <ja...@apache.org>
Date: 2015-05-20T04:54:44Z
CLOUDSTACK-8324: Added vm ip fetch logic
commit 42feaaddcabedd6cc712e5d4e9a16e5e74830c23
Author: Jayapal <ja...@apache.org>
Date: 2015-05-20T10:19:26Z
CLOUDSTACK-8324: Resource base changes for vm ip fetch
commit b400fdcc3256eb536f60a4f8bb42d1538af505bb
Author: Jayapal <ja...@apache.org>
Date: 2015-05-26T04:35:39Z
CLOUDSTACK-8324: Added config drive support for xenserver
commit 1d36e86a3922a3ff32ec56df81523193cbe7a28c
Author: Jayapal <ja...@apache.org>
Date: 2015-05-26T09:12:41Z
CLOUDSTACK-8324: Config drive changes for xenserver
commit 3c1897a1012f4e1bb49239757d0519f03dcb91a6
Author: Jayapal <ja...@apache.org>
Date: 2015-05-26T12:33:23Z
CLOUDSTACK-8324: Added unit test cases for GetVmIpAddressCommand
commit 0ddf28a54a5337e301e2e82519d0ba3ceb8c5a11
Author: Jayapal <ja...@apache.org>
Date: 2015-05-27T06:52:29Z
CLOUDSTACK-8324: Updated import and added ResourceWrapper annotation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Dhcp dns offload feature code changes
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/315#issuecomment-106197052
Looks good. i cannot judge the functionality (even after reading the FS) use case makes sense and asfbot and travis seem to agree nothing else is going to suffer so let's merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Dhcp dns offload feature code changes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Dhcp dns offload feature code changes
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/315#issuecomment-106040557
@ydder Looks Good. Good to see you added a unit test as well. In your description of how to do a test of the overall feature I am missing what the 'config drive iso' is. Do you have an fs-page or mail-link?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Dhcp dns offload feature code changes
Posted by ydder <gi...@git.apache.org>.
Github user ydder commented on the pull request:
https://github.com/apache/cloudstack/pull/315#issuecomment-106164654
@DaanHoogland FS link is there in ticket. Please find the it below
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=53740797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---