You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "Standing-Man (via GitHub)" <gi...@apache.org> on 2026/05/14 12:18:12 UTC

[I] Improve pre-push hook granularity and CI maintenance checks [iggy]

Standing-Man opened a new issue, #3258:
URL: https://github.com/apache/iggy/issues/3258

   ### Description
   
   ## Background
   
   The current pre-merge CI already has component detection for language-specific jobs, but several checks still run broadly:
   
   - If the files being pushed do not include files relevant to a language/tool, that language/tool hook should not run.
   - `Check PR Title` does not rerun when a PR title is edited.
   - common checks in `_common.yml` always run, even when the changed files cannot affect that check.
   - `scripts/ci/license-headers.sh` still has a Docker fallback for `addlicense`.
   
   We should tighten CI execution so PRs run the checks that are relevant to the changed files, while preserving dependency-driven coverage for core changes.
   
   ## Goals
   
   1.  Make pre-push hooks run only when the pushed changes include files relevant to that hook.
   2. Ensure PR title validation reruns after a PR title is edited.
   3. Remove Docker from the license-header check path and evaluate replacing `addlicense` with HawkEye.
   
   ### Component
   
   None
   
   ### Proposed solution
   
   _No response_
   
   ### Alternatives considered
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve pre-push hook granularity and CI maintenance checks [iggy]

Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on issue #3258:
URL: https://github.com/apache/iggy/issues/3258#issuecomment-4532478348

   I think for point 3 you can ignore it, check what @krishvishal did couple of months ago in https://github.com/apache/iggy/pull/3095


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve pre-push hook granularity and CI maintenance checks [iggy]

Posted by "Standing-Man (via GitHub)" <gi...@apache.org>.
Standing-Man commented on issue #3258:
URL: https://github.com/apache/iggy/issues/3258#issuecomment-4532563965

   > I think for point 3 you can ignore it, check what [@krishvishal](https://github.com/krishvishal) did couple of months ago in [#3095](https://github.com/apache/iggy/pull/3095)
   
   I think it still makes sense to replace the `Docker-based` `addlicense` check with `HawkEye` for license-header validation, because:
   
   1. The current addlicense `Docker` image only provides an `AMD64` build, which causes noticeable performance overhead on other architectures.
   2. Spinning up a Docker container for every pre-commit license-header check feels unnecessarily heavy and inconvenient for local development workflows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve pre-push hook granularity and CI maintenance checks [iggy]

Posted by "Standing-Man (via GitHub)" <gi...@apache.org>.
Standing-Man commented on issue #3258:
URL: https://github.com/apache/iggy/issues/3258#issuecomment-4749908463

   This has been completed. Closing this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Improve pre-push hook granularity and CI maintenance checks [iggy]

Posted by "Standing-Man (via GitHub)" <gi...@apache.org>.
Standing-Man closed issue #3258: Improve pre-push hook granularity and CI maintenance checks
URL: https://github.com/apache/iggy/issues/3258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org