You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/03/26 07:49:28 UTC
[GitHub] [lucene-solr] MarcusSorealheis opened a new pull request #1382:
Remove auto rep solr 12720
MarcusSorealheis opened a new pull request #1382: Remove auto rep solr 12720
URL: https://github.com/apache/lucene-solr/pull/1382
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-12720: this resolves the issue of removing the rule-based replica placement stategy.
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
There is something problematic that was deprecated a while ago that is no gone.
# Solution
I removed the the deprecated object and its associated artifacts and added how users could still leverage the API for trigger configuration if they so choose.
# Tests
No change to any test.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis closed pull request #1382:
SOLR-12720 Remove autoReplicaFailoverWaitAfterExpiration
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis closed pull request #1382: SOLR-12720 Remove autoReplicaFailoverWaitAfterExpiration
URL: https://github.com/apache/lucene-solr/pull/1382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] shalinmangar commented on a change in pull request
#1382: SOLR-12720 Remove autoReplicaFailoverWaitAfterExpiration
Posted by GitBox <gi...@apache.org>.
shalinmangar commented on a change in pull request #1382: SOLR-12720 Remove autoReplicaFailoverWaitAfterExpiration
URL: https://github.com/apache/lucene-solr/pull/1382#discussion_r403046954
##########
File path: solr/core/src/java/org/apache/solr/cloud/autoscaling/OverseerTriggerThread.java
##########
@@ -366,7 +366,6 @@ private AutoScalingConfig withDefaultTrigger(Map<String, Object> triggerProps, A
}
}
// need to add
- triggerProps.computeIfPresent("waitFor", (k, v) -> (long) (cloudConfig.getAutoReplicaFailoverWaitAfterExpiration() / 1000));
Review comment:
We need to add a default value here instead of of outright removing this line. Use the default value which is in `CloudConfig.DEFAULT_AUTO_REPLICA_FAILOVER_WAIT_AFTER_EXPIRATION` and set to 2 minutes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1382: Remove
auto rep solr 12720
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #1382: Remove auto rep solr 12720
URL: https://github.com/apache/lucene-solr/pull/1382#issuecomment-604491233
I’m sorry. It should be there. I opened it sleepily. I’ll fix.
On Thu, Mar 26, 2020 at 05:51 Cassandra Targett <no...@github.com>
wrote:
> @MarcusSorealheis <https://github.com/MarcusSorealheis> What's the
> associated Jira issue for this? I think you meant SOLR-12720? The format to
> use so the PR and the Jira are properly linked is to use the full form, as
> in SOLR-12720.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/lucene-solr/pull/1382#issuecomment-604413217>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAR6TSFTE7WPGEHK3RLWEU3RJNFWRANCNFSM4LUAYPKA>
> .
>
--
Marcus Eagan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on issue #1382: Remove auto rep
solr 12720
Posted by GitBox <gi...@apache.org>.
ctargett commented on issue #1382: Remove auto rep solr 12720
URL: https://github.com/apache/lucene-solr/pull/1382#issuecomment-604413217
@MarcusSorealheis What's the associated Jira issue for this? I think you meant SOLR-12720? The format to use so the PR and the Jira are properly linked is to use the full form, as in `SOLR-12720`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] MarcusSorealheis commented on issue #1382: SOLR-12720
Remove autoReplicaFailoverWaitAfterExpiration
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #1382: SOLR-12720 Remove autoReplicaFailoverWaitAfterExpiration
URL: https://github.com/apache/lucene-solr/pull/1382#issuecomment-604513220
@ctargett Thank you for catching that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett edited a comment on issue #1382: Remove auto
rep solr 12720
Posted by GitBox <gi...@apache.org>.
ctargett edited a comment on issue #1382: Remove auto rep solr 12720
URL: https://github.com/apache/lucene-solr/pull/1382#issuecomment-604413217
@MarcusSorealheis What's the associated Jira issue for this? I think you meant SOLR-12720? The format to use so the PR and the Jira are properly linked is to use the full form in the PR title, as in `SOLR-12720`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] shalinmangar commented on a change in pull request
#1382: SOLR-12720 Remove autoReplicaFailoverWaitAfterExpiration
Posted by GitBox <gi...@apache.org>.
shalinmangar commented on a change in pull request #1382: SOLR-12720 Remove autoReplicaFailoverWaitAfterExpiration
URL: https://github.com/apache/lucene-solr/pull/1382#discussion_r398972311
##########
File path: solr/solr-ref-guide/src/solrcloud-autoscaling-triggers.adoc
##########
@@ -205,11 +205,30 @@ to add replicas on the live nodes to maintain the expected replication factor).
Refer to the section <<solrcloud-autoscaling-auto-add-replicas.adoc#solrcloud-autoscaling-auto-add-replicas, Autoscaling Automatically Adding Replicas>> to learn more about how the `.autoAddReplicas` trigger works.
-In addition to the parameters described at <<Trigger Configuration>>, this trigger supports one parameter, which is defined in the `<solrcloud>` section of `solr.xml`:
-
-`autoReplicaFailoverWaitAfterExpiration`::
-The minimum time in milliseconds to wait for initiating replacement of a replica after first noticing it not being live. This is important to prevent false positives while stopping or starting the cluster. The default is `120000` (2 minutes). The value provided for this parameter is used as the value for the `waitFor` parameter in the `.auto_add_replicas` trigger.
+If you would like to change the value of `.autoAddReplicas` trigger, you need to call the autoscaling API and use the `set-trigger` command to add a value for `waitFor`.
+.Example: Updating Trigger with wait for 5 seconds
+}
+----
+{
+ "set-trigger": {
+ "name": "name_of_auto_add_trigger",
Review comment:
The name of the trigger is always `.auto_add_replicas`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org