[jira] [Work logged] (HIVE-23354) Remove file size sanity checking from compareTempOrDuplicateFiles

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-23354?focusedWorklogId=434225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434225 ]

ASF GitHub Bot logged work on HIVE-23354:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/May/20 18:00
            Start Date: 17/May/20 18:00
    Worklog Time Spent: 10m 
      Work Description: jfsii opened a new pull request #1022:
URL: https://github.com/apache/hive/pull/1022


   …ateFiles
   
   Change-Id: I12a76ff1c98e10941e7ef76932a5249ed4a5472a


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 434225)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove file size sanity checking from compareTempOrDuplicateFiles
> -----------------------------------------------------------------
>
>                 Key: HIVE-23354
>                 URL: https://issues.apache.org/jira/browse/HIVE-23354
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>            Reporter: John Sherman
>            Assignee: John Sherman
>            Priority: Major
>         Attachments: HIVE-23354.1.patch, HIVE-23354.2.patch, HIVE-23354.3.patch, HIVE-23354.4.patch, HIVE-23354.5.patch, HIVE-23354.6.patch, HIVE-23354.7.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> [https://github.com/apache/hive/blob/cdd55aa319a3440963a886ebfff11cd2a240781d/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java#L1952-L2010]
>  compareTempOrDuplicateFiles uses a combination of attemptId and fileSize to determine which file(s) to keep.
>  I've seen instances where this function throws an exception due to the fact that the newer attemptId file size is less than the older attemptId (thus failing the query).
>  I think this assumption is faulty, due to various factors such as file compression and the order in which values are written. It may be prudent to trust that the newest attemptId is in fact the best choice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)