[PATCH]

["Peter N. Lundblad" <pe...@famlundblad.se>]

Hi,

I'd like to commit the attached patch to HACKING. It allows modifications
to .po files during release stabilization. I think none formatting % code
changes are safe and shouldn't require voting, but changes involving %
should.

Comments?

//Peter

Re: [PATCH]

["Peter N. Lundblad" <pe...@famlundblad.se>]

On Mon, 12 Jul 2004, Justin Erenkrantz wrote:

> --On Monday, July 12, 2004 4:07 PM +0200 "Peter N. Lundblad"
> <pe...@famlundblad.se> wrote:
>
> > are in msgfmt -c being correct. On the other hand, requiring restart of
> > the soak month just because of a bug in a .po formatting string would be
> > very paranoid. But if people don't like this, I can drop it. The most
>
> I don't understand how you think a 'bug in a .po formatting string' would
> differ than a 'bug in a formatting string.'  Aren't they identical?  Or,
> are you only talking about the string in the .po not the one in the .c
> files?  My impression was that you are talking about tweaking the format
> strings in the .c files that the .po keys off.  -- justin
>
I am talking about translations, i.e. msgstr strings. The msgids are dealt
with elsewhere.

Ofcourse, a bug in a formatting string is a bug is a bug is a bug. The
difference is that if you change a formatting string in a C file (or the
varargs arguments in the function call), you can introduce bugs, possibly
on other platforms that you don't detect. With translations, msgfmt can
detect formatting string mismatches. So, it shouldn't be easy to introduce
bugs in .po files if you validate them.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH]

[Justin Erenkrantz <ju...@erenkrantz.com>]

--On Monday, July 12, 2004 4:07 PM +0200 "Peter N. Lundblad" 
<pe...@famlundblad.se> wrote:

> are in msgfmt -c being correct. On the other hand, requiring restart of
> the soak month just because of a bug in a .po formatting string would be
> very paranoid. But if people don't like this, I can drop it. The most

I don't understand how you think a 'bug in a .po formatting string' would 
differ than a 'bug in a formatting string.'  Aren't they identical?  Or, 
are you only talking about the string in the .po not the one in the .c 
files?  My impression was that you are talking about tweaking the format 
strings in the .c files that the .po keys off.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH]

["Peter N. Lundblad" <pe...@famlundblad.se>]

On Sun, 11 Jul 2004, Justin Erenkrantz wrote:

> --On Monday, July 12, 2004 1:05 AM +0200 "Peter N. Lundblad"
> <pe...@famlundblad.se> wrote:
>
> > I'd like to commit the attached patch to HACKING. It allows modifications
> > to .po files during release stabilization.
>
> That's fine, I think.
>
> > I think none formatting % code
> > changes are safe and shouldn't require voting, but changes involving %
> > should.
>
> I don't think those are safe at all to be made during release stabilization -
> we don't allow format strings to change during this phase now.  -- justin
>
But we have a tool to check formatting strings for translations, namely
GNU msgfmt with the -c option. The idea is that requiring voting, someonw
will have run msgfmt -c on the file. But that depends on how confident we
are in msgfmt -c being correct. On the other hand, requiring restart of
the soak month just because of a bug in a .po formatting string would be
very paranoid. But if people don't like this, I can drop it. The most
important thing is to be able to fix typos in messages (see my last commit
to sv.po:-)...

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH]

[Justin Erenkrantz <ju...@erenkrantz.com>]

--On Monday, July 12, 2004 1:05 AM +0200 "Peter N. Lundblad" 
<pe...@famlundblad.se> wrote:

> I'd like to commit the attached patch to HACKING. It allows modifications
> to .po files during release stabilization.

That's fine, I think.

> I think none formatting % code
> changes are safe and shouldn't require voting, but changes involving %
> should.

I don't think those are safe at all to be made during release stabilization - 
we don't allow format strings to change during this phase now.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org