You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/09/09 02:49:54 UTC

[GitHub] [rocketmq] lizhanhui commented on pull request #5017: 5.0.0 beta compact

lizhanhui commented on PR #5017:
URL: https://github.com/apache/rocketmq/pull/5017#issuecomment-1241437602

   It's a huge pull request and massive modifications to critical parts.  It would be good to split it into multiple smaller ones so we can have quality reviews. 
   
   The open-close principle should be seriously considered after a quick review of the change. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org