[GitHub] [calcite] DonnyZone commented on a change in pull request #2530: [CALCITE-4532] Correct code generated for primitive-object ConstantExpression

[GitBox <gi...@apache.org>]

DonnyZone commented on a change in pull request #2530:
URL: https://github.com/apache/calcite/pull/2530#discussion_r715425762



##########
File path: linq4j/src/test/java/org/apache/calcite/linq4j/test/ExpressionTest.java
##########
@@ -1357,6 +1357,25 @@ public void checkBlockBuilder(boolean optimizing, String expected) {
         Expressions.toString(Expressions.constant(12.34, BigDecimal.class)));
   }
 
+  @Test void testObjectConstantExpression() {
+    assertEquals("true",
+        Expressions.toString(Expressions.constant(true, Object.class)));
+    assertEquals("(byte)100",
+        Expressions.toString(Expressions.constant((byte) 100, Object.class)));
+    assertEquals("(char)100",
+        Expressions.toString(Expressions.constant((char) 100, Object.class)));
+    assertEquals("(short)100",
+        Expressions.toString(Expressions.constant((short) 100, Object.class)));
+    assertEquals("100",
+        Expressions.toString(Expressions.constant(100, Object.class)));
+    assertEquals("100L",
+        Expressions.toString(Expressions.constant(100L, Object.class)));
+    assertEquals("100.0F",
+        Expressions.toString(Expressions.constant(100F, Object.class)));
+    assertEquals("100.0D",
+        Expressions.toString(Expressions.constant(100D, Object.class)));
+  }
+

Review comment:
       The following two test case also pass without this commit. We can remove them.
   ```
       assertEquals("true",
           Expressions.toString(Expressions.constant(true, Object.class)));
       assertEquals("100",
           Expressions.toString(Expressions.constant(100, Object.class)));
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org