You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/26 23:46:09 UTC
[GitHub] [nifi] alopresto opened a new pull request #4017: NIFI-7012 Added logic to bypass sensitive property descriptor check o…
alopresto opened a new pull request #4017: NIFI-7012 Added logic to bypass sensitive property descriptor check o…
URL: https://github.com/apache/nifi/pull/4017
…n scriptable component PD during startup.
Created ScriptableComponent interface in nifi-api to allow for detection of scriptable components.
Added interface to scriptable processors (controller services still outstanding).
Changed detection method to instanceof vs. explicit string comparison.
Added utility method to detect scriptable components.
Added null check before running validation trigger.
Added logging for debugging.
Extracted HashMapParameterReferenceManager to reusable test class.
Deduplicated class definitions in StandardFlowSynchronizer.
Fixed test failure in ExecuteGroovyScriptTest where preloads and script body were concatenated without space causing compilation errors.
Enabled additional scriptable components.
Changed scriptable detection to use inheritance throughout codebase rather than explicit classname allowlist.
Added unit tests.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_If a scriptable processor (`InvokeScriptedProcessor`, `ExecuteScript`, or `ExecuteGroovyScript`) created a property descriptor and marked it as *sensitive*, then assigned a sensitive parameter to this property, on startup the application would fail and shutdown because the property descriptor sensitive state was not serialized to the `flow.xml.gz` file, as previously there was no such offering for a sensitive property descriptor that was not defined in the native processor. The startup now detects this scenario, prints a warning to the log, and treats the property descriptor as sensitive moving forward._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] markap14 commented on issue #4017: NIFI-7012 Added logic to bypass sensitive property descriptor check o…
Posted by GitBox <gi...@apache.org>.
markap14 commented on issue #4017: NIFI-7012 Added logic to bypass sensitive property descriptor check o…
URL: https://github.com/apache/nifi/pull/4017#issuecomment-579970202
Closing this PR as @alopresto mentioned in the Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] markap14 closed pull request #4017: NIFI-7012 Added logic to bypass sensitive property descriptor check o…
Posted by GitBox <gi...@apache.org>.
markap14 closed pull request #4017: NIFI-7012 Added logic to bypass sensitive property descriptor check o…
URL: https://github.com/apache/nifi/pull/4017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services